summaryrefslogtreecommitdiff
path: root/src/effects/placeholder_effect.cc
diff options
context:
space:
mode:
authorskal <pascal.massimino@gmail.com>2026-02-17 13:05:11 +0100
committerskal <pascal.massimino@gmail.com>2026-02-17 13:05:11 +0100
commitbdb1a4e95a545f3f4d88630b8aec6ab771776d99 (patch)
tree97a3a15381a7ff9780644ec8876535dd219f23cf /src/effects/placeholder_effect.cc
parenta32c7456588abf4f44866d0c055fa94d105e8ef7 (diff)
refactor(effects): Streamline uniforms initialization
Centralized uniforms_buffer_ initialization and updates to Effect base class: - init_uniforms_buffer() now automatic in Effect::Effect() - uniforms_buffer_.update() now automatic in dispatch_render() - Removed redundant calls from all effect subclasses - Updated effect.h comments to reflect automatic behavior - Updated EFFECT_WORKFLOW.md templates Benefits: - 16 lines removed from effect implementations - Consistent pattern enforced at compile time - Reduced boilerplate for new effects Tests: 34/34 passing handoff(Claude): Effect base class now handles uniforms automatically
Diffstat (limited to 'src/effects/placeholder_effect.cc')
-rw-r--r--src/effects/placeholder_effect.cc3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/effects/placeholder_effect.cc b/src/effects/placeholder_effect.cc
index e024a6b..beb5f33 100644
--- a/src/effects/placeholder_effect.cc
+++ b/src/effects/placeholder_effect.cc
@@ -17,7 +17,6 @@ Placeholder::Placeholder(const GpuContext& ctx,
HEADLESS_RETURN_IF_NULL(ctx_.device);
- init_uniforms_buffer();
create_linear_sampler();
pipeline_ = create_post_process_pipeline(
@@ -30,8 +29,6 @@ void Placeholder::render(WGPUCommandEncoder encoder,
WGPUTextureView input_view = nodes.get_view(input_nodes_[0]);
WGPUTextureView output_view = nodes.get_view(output_nodes_[0]);
- uniforms_buffer_.update(ctx_.queue, params);
-
pp_update_bind_group(ctx_.device, pipeline_, &bind_group_, input_view,
uniforms_buffer_.get(), {nullptr, 0});