diff options
| author | skal <pascal.massimino@gmail.com> | 2026-02-05 20:21:33 +0100 |
|---|---|---|
| committer | skal <pascal.massimino@gmail.com> | 2026-02-05 20:21:33 +0100 |
| commit | 66e80234e69a59193e91b0f9e2ea90fca36e1c67 (patch) | |
| tree | 633b2f7c396e93115f4df987e7078643276d377c /src | |
| parent | 12816810855883472ecab454f9c0d08d66f0ae52 (diff) | |
fix(gpu): Resolve typeid warning by using .get() on shared_ptr
Fixed warning: "expression with side effects will be evaluated despite
being used as an operand to 'typeid'"
Changed from:
typeid(*item.effect).name()
To:
Effect* effect_ptr = item.effect.get();
typeid(*effect_ptr).name()
This avoids potential side effects from dereferencing the shared_ptr
directly in typeid expression.
All 20 tests pass (100%).
Diffstat (limited to 'src')
| -rw-r--r-- | src/gpu/effect.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/gpu/effect.cc b/src/gpu/effect.cc index 8ae5835..b95c4ce 100644 --- a/src/gpu/effect.cc +++ b/src/gpu/effect.cc @@ -61,7 +61,8 @@ void Sequence::update_active_list(float seq_time) { if (should_be_active && !item.active) { #if !defined(STRIP_ALL) - const char* effect_name = typeid(*item.effect).name(); + Effect* effect_ptr = item.effect.get(); + const char* effect_name = typeid(*effect_ptr).name(); printf(" [EFFECT START] %s (priority=%d, time=%.2f-%.2f)\n", effect_name, item.priority, item.start_time, item.end_time); #endif @@ -69,7 +70,8 @@ void Sequence::update_active_list(float seq_time) { item.active = true; } else if (!should_be_active && item.active) { #if !defined(STRIP_ALL) - const char* effect_name = typeid(*item.effect).name(); + Effect* effect_ptr = item.effect.get(); + const char* effect_name = typeid(*effect_ptr).name(); printf(" [EFFECT END] %s (priority=%d)\n", effect_name, item.priority); #endif item.effect->end(); |