summaryrefslogtreecommitdiff
path: root/src/audio/backend
diff options
context:
space:
mode:
authorskal <pascal.massimino@gmail.com>2026-05-20 22:44:44 +0200
committerskal <pascal.massimino@gmail.com>2026-05-20 22:44:44 +0200
commit5d20c892dedce7bc7486acbd72fbd35da69e413e (patch)
tree05e04d5e689504c2421cd5772e91a42ee69608ab /src/audio/backend
parent6ef8f578817ee0134fd5867ca3b80590e3eb2368 (diff)
fix: code review cleanup — bugs, dead code, factorization (-167 lines)
Bugs: - B1: fix dead tempo debug (prev_tempo captured after assignment) - B2: fix ReloadAssetsFromFile leak for disk-loaded assets; simplify DropAsset - B3: fix get_free_pool_slot leak (unregister synth + free data on reuse) - B4: volatile -> std::atomic with acquire/release in miniaudio_backend, synth - B5: fix unaligned reads in scene_loader (memcpy-based read_f32/read_u32) - B6: fix shader module + BGL + pipeline layout leaks in gpu.cc, pipeline_builder Dead code: - D1: remove unused particle_defs.h - D3: remove create_post_process_pipeline_simple (zero callers) - D4: remove empty gpu_draw() - D5: remove write-only Hybrid3D::initialized_ - D6: remove legacy pending buffer path in audio.cc Factorization: - F1: Effect::run_fullscreen_pass() replaces boilerplate in 5 effects - F2: particle_common.wgsl snippet, #include in 3 WGSL shaders - F3: gpu_create_shader_module() helper, used in 3 call sites - F5: get_world_aabb() shared between bvh.cc and physics.cc - F6: samples_to_seconds() replaces 6 inline expressions - F7: gpu_create_linear/nearest_sampler use SamplerCache; add nearest() preset 37/37 tests passing. handoff(Claude): code review batch — all items verified, no regressions.
Diffstat (limited to 'src/audio/backend')
-rw-r--r--src/audio/backend/miniaudio_backend.cc20
-rw-r--r--src/audio/backend/miniaudio_backend.h8
2 files changed, 16 insertions, 12 deletions
diff --git a/src/audio/backend/miniaudio_backend.cc b/src/audio/backend/miniaudio_backend.cc
index 312d36e..8871d10 100644
--- a/src/audio/backend/miniaudio_backend.cc
+++ b/src/audio/backend/miniaudio_backend.cc
@@ -12,11 +12,11 @@
// Real-time peak measured at actual playback time
// Updated in audio_callback when samples are read from ring buffer
-volatile float MiniaudioBackend::realtime_peak_ = 0.0f;
+std::atomic<float> MiniaudioBackend::realtime_peak_{0.0f};
// Smooth playback time interpolation
-volatile double MiniaudioBackend::last_callback_time_ = 0.0;
-volatile int64_t MiniaudioBackend::last_callback_samples_ = 0;
+std::atomic<double> MiniaudioBackend::last_callback_time_{0.0};
+std::atomic<int64_t> MiniaudioBackend::last_callback_samples_{0};
// Static callback for miniaudio (C API requirement)
void MiniaudioBackend::audio_callback(ma_device* pDevice, void* pOutput,
@@ -148,8 +148,10 @@ void MiniaudioBackend::audio_callback(ma_device* pDevice, void* pOutput,
// Update smooth playback time tracking (absolute time, no epoch needed)
struct timespec ts;
clock_gettime(CLOCK_MONOTONIC, &ts);
- last_callback_time_ = ts.tv_sec + ts.tv_nsec / 1e9;
- last_callback_samples_ = ring_buffer->get_total_read();
+ last_callback_time_.store(ts.tv_sec + ts.tv_nsec / 1e9,
+ std::memory_order_release);
+ last_callback_samples_.store(ring_buffer->get_total_read(),
+ std::memory_order_release);
#if defined(DEBUG_LOG_RING_BUFFER)
if (actually_read < samples_to_read) {
@@ -280,11 +282,11 @@ void MiniaudioBackend::shutdown() {
}
float MiniaudioBackend::get_realtime_peak() {
- return realtime_peak_;
+ return realtime_peak_.load(std::memory_order_acquire);
}
void MiniaudioBackend::get_callback_state(double* out_time,
- int64_t* out_samples) {
- *out_time = last_callback_time_;
- *out_samples = last_callback_samples_;
+ int64_t* out_samples) {
+ *out_time = last_callback_time_.load(std::memory_order_acquire);
+ *out_samples = last_callback_samples_.load(std::memory_order_acquire);
}
diff --git a/src/audio/backend/miniaudio_backend.h b/src/audio/backend/miniaudio_backend.h
index 953a0c0..01fa790 100644
--- a/src/audio/backend/miniaudio_backend.h
+++ b/src/audio/backend/miniaudio_backend.h
@@ -6,6 +6,8 @@
#include "../audio_backend.h"
#include "miniaudio.h"
+#include <atomic>
+#include <cstdint>
// Production audio backend using miniaudio library
// Manages real hardware audio device and playback
@@ -31,11 +33,11 @@ class MiniaudioBackend : public AudioBackend {
// Real-time peak measured at actual playback time (not pre-buffer)
// Updated in audio_callback when samples are read from ring buffer
- static volatile float realtime_peak_;
+ static std::atomic<float> realtime_peak_;
// Smooth playback time interpolation (updated in callback)
- static volatile double last_callback_time_; // Absolute CLOCK_MONOTONIC time
- static volatile int64_t last_callback_samples_;
+ static std::atomic<double> last_callback_time_; // Absolute CLOCK_MONOTONIC time
+ static std::atomic<int64_t> last_callback_samples_;
// Static callback required by miniaudio C API
static void audio_callback(ma_device* pDevice, void* pOutput,