From 5d20c892dedce7bc7486acbd72fbd35da69e413e Mon Sep 17 00:00:00 2001 From: skal Date: Wed, 20 May 2026 22:44:44 +0200 Subject: fix: code review cleanup — bugs, dead code, factorization (-167 lines) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bugs: - B1: fix dead tempo debug (prev_tempo captured after assignment) - B2: fix ReloadAssetsFromFile leak for disk-loaded assets; simplify DropAsset - B3: fix get_free_pool_slot leak (unregister synth + free data on reuse) - B4: volatile -> std::atomic with acquire/release in miniaudio_backend, synth - B5: fix unaligned reads in scene_loader (memcpy-based read_f32/read_u32) - B6: fix shader module + BGL + pipeline layout leaks in gpu.cc, pipeline_builder Dead code: - D1: remove unused particle_defs.h - D3: remove create_post_process_pipeline_simple (zero callers) - D4: remove empty gpu_draw() - D5: remove write-only Hybrid3D::initialized_ - D6: remove legacy pending buffer path in audio.cc Factorization: - F1: Effect::run_fullscreen_pass() replaces boilerplate in 5 effects - F2: particle_common.wgsl snippet, #include in 3 WGSL shaders - F3: gpu_create_shader_module() helper, used in 3 call sites - F5: get_world_aabb() shared between bvh.cc and physics.cc - F6: samples_to_seconds() replaces 6 inline expressions - F7: gpu_create_linear/nearest_sampler use SamplerCache; add nearest() preset 37/37 tests passing. handoff(Claude): code review batch — all items verified, no regressions. --- src/audio/backend/miniaudio_backend.cc | 20 +++++++++++--------- src/audio/backend/miniaudio_backend.h | 8 +++++--- 2 files changed, 16 insertions(+), 12 deletions(-) (limited to 'src/audio/backend') diff --git a/src/audio/backend/miniaudio_backend.cc b/src/audio/backend/miniaudio_backend.cc index 312d36e..8871d10 100644 --- a/src/audio/backend/miniaudio_backend.cc +++ b/src/audio/backend/miniaudio_backend.cc @@ -12,11 +12,11 @@ // Real-time peak measured at actual playback time // Updated in audio_callback when samples are read from ring buffer -volatile float MiniaudioBackend::realtime_peak_ = 0.0f; +std::atomic MiniaudioBackend::realtime_peak_{0.0f}; // Smooth playback time interpolation -volatile double MiniaudioBackend::last_callback_time_ = 0.0; -volatile int64_t MiniaudioBackend::last_callback_samples_ = 0; +std::atomic MiniaudioBackend::last_callback_time_{0.0}; +std::atomic MiniaudioBackend::last_callback_samples_{0}; // Static callback for miniaudio (C API requirement) void MiniaudioBackend::audio_callback(ma_device* pDevice, void* pOutput, @@ -148,8 +148,10 @@ void MiniaudioBackend::audio_callback(ma_device* pDevice, void* pOutput, // Update smooth playback time tracking (absolute time, no epoch needed) struct timespec ts; clock_gettime(CLOCK_MONOTONIC, &ts); - last_callback_time_ = ts.tv_sec + ts.tv_nsec / 1e9; - last_callback_samples_ = ring_buffer->get_total_read(); + last_callback_time_.store(ts.tv_sec + ts.tv_nsec / 1e9, + std::memory_order_release); + last_callback_samples_.store(ring_buffer->get_total_read(), + std::memory_order_release); #if defined(DEBUG_LOG_RING_BUFFER) if (actually_read < samples_to_read) { @@ -280,11 +282,11 @@ void MiniaudioBackend::shutdown() { } float MiniaudioBackend::get_realtime_peak() { - return realtime_peak_; + return realtime_peak_.load(std::memory_order_acquire); } void MiniaudioBackend::get_callback_state(double* out_time, - int64_t* out_samples) { - *out_time = last_callback_time_; - *out_samples = last_callback_samples_; + int64_t* out_samples) { + *out_time = last_callback_time_.load(std::memory_order_acquire); + *out_samples = last_callback_samples_.load(std::memory_order_acquire); } diff --git a/src/audio/backend/miniaudio_backend.h b/src/audio/backend/miniaudio_backend.h index 953a0c0..01fa790 100644 --- a/src/audio/backend/miniaudio_backend.h +++ b/src/audio/backend/miniaudio_backend.h @@ -6,6 +6,8 @@ #include "../audio_backend.h" #include "miniaudio.h" +#include +#include // Production audio backend using miniaudio library // Manages real hardware audio device and playback @@ -31,11 +33,11 @@ class MiniaudioBackend : public AudioBackend { // Real-time peak measured at actual playback time (not pre-buffer) // Updated in audio_callback when samples are read from ring buffer - static volatile float realtime_peak_; + static std::atomic realtime_peak_; // Smooth playback time interpolation (updated in callback) - static volatile double last_callback_time_; // Absolute CLOCK_MONOTONIC time - static volatile int64_t last_callback_samples_; + static std::atomic last_callback_time_; // Absolute CLOCK_MONOTONIC time + static std::atomic last_callback_samples_; // Static callback required by miniaudio C API static void audio_callback(ma_device* pDevice, void* pOutput, -- cgit v1.2.3