1 files changed, 57 insertions, 10 deletions

diff --git a/src/gpu/demo_effects.h b/src/gpu/demo_effects.h
index cddd04b..6c8729d 100644
--- a/src/gpu/demo_effects.h
+++ b/src/gpu/demo_effects.h
@@ -6,10 +6,12 @@
 #include "3d/renderer.h"
 #include "3d/scene.h"
 #include "effect.h"
+#include "gpu/effects/flash_effect.h" // FlashEffect with params support
 #include "gpu/effects/post_process_helper.h"
 #include "gpu/effects/shaders.h"
 #include "gpu/gpu.h"
 #include "gpu/texture_manager.h"
+#include "gpu/uniform_helper.h"
 #include <memory>
 
 static const int NUM_PARTICLES = 10000;
@@ -75,12 +77,38 @@ class ParticleSprayEffect : public Effect {
   GpuBuffer particles_buffer_;
 };
 
+// Parameters for GaussianBlurEffect (set at construction time)
+struct GaussianBlurParams {
+  float strength = 2.0f; // Default: 2.0 pixel blur radius
+};
+
+// Uniform data sent to GPU shader
+struct GaussianBlurUniforms {
+  float time;         // offset 0
+  float beat;         // offset 4
+  float intensity;    // offset 8
+  float aspect_ratio; // offset 12
+  float width;        // offset 16
+  float height;       // offset 20
+  float strength;     // offset 24
+  float _pad;         // offset 28
+};
+static_assert(sizeof(GaussianBlurUniforms) == 32,
+              "GaussianBlurUniforms must be 32 bytes for WGSL alignment");
+
 class GaussianBlurEffect : public PostProcessEffect {
  public:
+  // Backward compatibility constructor (uses default params)
   GaussianBlurEffect(const GpuContext& ctx);
+  // New parameterized constructor
+  GaussianBlurEffect(const GpuContext& ctx, const GaussianBlurParams& params);
   void render(WGPURenderPassEncoder pass, float time, float beat,
               float intensity, float aspect_ratio) override;
   void update_bind_group(WGPUTextureView input_view) override;
+
+ private:
+  GaussianBlurParams params_;
+  UniformBuffer<GaussianBlurUniforms> uniforms_;
 };
 
 class SolarizeEffect : public PostProcessEffect {
@@ -99,12 +127,40 @@ class DistortEffect : public PostProcessEffect {
   void update_bind_group(WGPUTextureView input_view) override;
 };
 
+// Parameters for ChromaAberrationEffect (set at construction time)
+struct ChromaAberrationParams {
+  float offset_scale = 0.02f; // Default: 2% screen offset
+  float angle = 0.0f;         // Default: horizontal (0 radians)
+};
+
+// Uniform data sent to GPU shader
+struct ChromaUniforms {
+  float time;         // offset 0
+  float beat;         // offset 4
+  float intensity;    // offset 8
+  float aspect_ratio; // offset 12
+  float width;        // offset 16
+  float height;       // offset 20
+  float offset_scale; // offset 24
+  float angle;        // offset 28
+};
+static_assert(sizeof(ChromaUniforms) == 32,
+              "ChromaUniforms must be 32 bytes for WGSL alignment");
+
 class ChromaAberrationEffect : public PostProcessEffect {
  public:
+  // Backward compatibility constructor (uses default params)
   ChromaAberrationEffect(const GpuContext& ctx);
+  // New parameterized constructor
+  ChromaAberrationEffect(const GpuContext& ctx,
+                         const ChromaAberrationParams& params);
   void render(WGPURenderPassEncoder pass, float time, float beat,
               float intensity, float aspect_ratio) override;
   void update_bind_group(WGPUTextureView input_view) override;
+
+ private:
+  ChromaAberrationParams params_;
+  UniformBuffer<ChromaUniforms> uniforms_;
 };
 
 class Hybrid3DEffect : public Effect {
@@ -158,16 +214,7 @@ class FadeEffect : public PostProcessEffect {
   void update_bind_group(WGPUTextureView input_view) override;
 };
 
-class FlashEffect : public PostProcessEffect {
- public:
-  FlashEffect(const GpuContext& ctx);
-  void render(WGPURenderPassEncoder pass, float time, float beat,
-              float intensity, float aspect_ratio) override;
-  void update_bind_group(WGPUTextureView input_view) override;
-
- private:
-  float flash_intensity_ = 0.0f;
-};
+// FlashEffect now defined in gpu/effects/flash_effect.h (included above)
 
 // Auto-generated functions
 void LoadTimeline(MainSequence& main_seq, const GpuContext& ctx);