1 files changed, 22 insertions, 35 deletions

diff --git a/src/effects/placeholder_effect.cc b/src/effects/placeholder_effect.cc
index d8852da..e024a6b 100644
--- a/src/effects/placeholder_effect.cc
+++ b/src/effects/placeholder_effect.cc
@@ -1,41 +1,32 @@
-// Placeholder effect v2 implementation - logs TODO warning once
+// Placeholder effect implementation - logs TODO warning once
 
 #include "effects/placeholder_effect.h"
-#include "util/fatal_error.h"
+#include "effects/shaders.h"
 #include "gpu/post_process_helper.h"
-#include "gpu/shaders.h"
+#include "util/fatal_error.h"
 #include <cstdio>
 
-PlaceholderEffect::PlaceholderEffect(const GpuContext& ctx,
-                                         const std::vector<std::string>& inputs,
-                                         const std::vector<std::string>& outputs,
-                                         const char* placeholder_name)
-    : Effect(ctx, inputs, outputs), pipeline_(nullptr), bind_group_(nullptr),
-      sampler_(nullptr), name_(placeholder_name) {
-  // Log once on construction
-  fprintf(stderr, "TODO: %s not yet ported to v2, using passthrough\n", name_);
+Placeholder::Placeholder(const GpuContext& ctx,
+                         const std::vector<std::string>& inputs,
+                         const std::vector<std::string>& outputs,
+                         float start_time, float end_time,
+                         const char* placeholder_name)
+    : Effect(ctx, inputs, outputs, start_time, end_time), pipeline_(nullptr),
+      bind_group_(nullptr), name_(placeholder_name) {
+  fprintf(stderr, "TODO: %s not yet implemented, using passthrough\n", name_);
 
-  // Headless mode: skip GPU resource creation (compiled out in STRIP_ALL)
   HEADLESS_RETURN_IF_NULL(ctx_.device);
 
-  uniforms_buffer_.init(ctx_.device);
-  pipeline_ = create_post_process_pipeline(ctx_.device, WGPUTextureFormat_RGBA8Unorm,
-                                           passthrough_v2_shader_wgsl);
+  init_uniforms_buffer();
+  create_linear_sampler();
 
-  WGPUSamplerDescriptor sampler_desc = {};
-  sampler_desc.addressModeU = WGPUAddressMode_ClampToEdge;
-  sampler_desc.addressModeV = WGPUAddressMode_ClampToEdge;
-  sampler_desc.addressModeW = WGPUAddressMode_ClampToEdge;
-  sampler_desc.magFilter = WGPUFilterMode_Linear;
-  sampler_desc.minFilter = WGPUFilterMode_Linear;
-  sampler_desc.mipmapFilter = WGPUMipmapFilterMode_Nearest;
-  sampler_desc.maxAnisotropy = 1;
-  sampler_ = wgpuDeviceCreateSampler(ctx_.device, &sampler_desc);
+  pipeline_ = create_post_process_pipeline(
+      ctx_.device, WGPUTextureFormat_RGBA8Unorm, passthrough_shader_wgsl);
 }
 
-void PlaceholderEffect::render(WGPUCommandEncoder encoder,
-                                 const UniformsSequenceParams& params,
-                                 NodeRegistry& nodes) {
+void Placeholder::render(WGPUCommandEncoder encoder,
+                         const UniformsSequenceParams& params,
+                         NodeRegistry& nodes) {
   WGPUTextureView input_view = nodes.get_view(input_nodes_[0]);
   WGPUTextureView output_view = nodes.get_view(output_nodes_[0]);
 
@@ -44,19 +35,15 @@ void PlaceholderEffect::render(WGPUCommandEncoder encoder,
   pp_update_bind_group(ctx_.device, pipeline_, &bind_group_, input_view,
                        uniforms_buffer_.get(), {nullptr, 0});
 
-  WGPURenderPassColorAttachment color_attachment = {
-    .view = output_view,
-    .depthSlice = WGPU_DEPTH_SLICE_UNDEFINED,
-    .loadOp = WGPULoadOp_Clear,
-    .storeOp = WGPUStoreOp_Store,
-    .clearValue = {0.0, 0.0, 0.0, 1.0}
-  };
+  WGPURenderPassColorAttachment color_attachment = {};
+  gpu_init_color_attachment(color_attachment, output_view);
 
   WGPURenderPassDescriptor pass_desc = {};
   pass_desc.colorAttachmentCount = 1;
   pass_desc.colorAttachments = &color_attachment;
 
-  WGPURenderPassEncoder pass = wgpuCommandEncoderBeginRenderPass(encoder, &pass_desc);
+  WGPURenderPassEncoder pass =
+      wgpuCommandEncoderBeginRenderPass(encoder, &pass_desc);
   wgpuRenderPassEncoderSetPipeline(pass, pipeline_);
   wgpuRenderPassEncoderSetBindGroup(pass, 0, bind_group_, 0, nullptr);
   wgpuRenderPassEncoderDraw(pass, 3, 1, 0, 0);