1 files changed, 25 insertions, 44 deletions

diff --git a/src/effects/passthrough_effect.cc b/src/effects/passthrough_effect.cc
index 56e3711..24eefca 100644
--- a/src/effects/passthrough_effect.cc
+++ b/src/effects/passthrough_effect.cc
@@ -1,39 +1,27 @@
-// Passthrough effect v2 implementation
+// Passthrough effect implementation
 
 #include "effects/passthrough_effect.h"
-#include "util/fatal_error.h"
+#include "effects/shaders.h"
 #include "gpu/post_process_helper.h"
-#include "gpu/shaders.h"
+#include "util/fatal_error.h"
 
-PassthroughEffect::PassthroughEffect(const GpuContext& ctx,
-                                         const std::vector<std::string>& inputs,
-                                         const std::vector<std::string>& outputs)
-    : Effect(ctx, inputs, outputs), pipeline_(nullptr), bind_group_(nullptr),
-      sampler_(nullptr) {
-  // Headless mode: skip GPU resource creation (compiled out in STRIP_ALL)
+Passthrough::Passthrough(const GpuContext& ctx,
+                         const std::vector<std::string>& inputs,
+                         const std::vector<std::string>& outputs,
+                         float start_time, float end_time)
+    : Effect(ctx, inputs, outputs, start_time, end_time) {
   HEADLESS_RETURN_IF_NULL(ctx_.device);
 
-  // Init uniform buffer
-  uniforms_buffer_.init(ctx_.device);
-  // Create pipeline (simple version without effect params)
-  pipeline_ = create_post_process_pipeline_simple(ctx_.device, WGPUTextureFormat_RGBA8Unorm,
-                                                  passthrough_v2_shader_wgsl);
+  init_uniforms_buffer();
+  create_linear_sampler();
 
-  // Create sampler
-  WGPUSamplerDescriptor sampler_desc = {};
-  sampler_desc.addressModeU = WGPUAddressMode_ClampToEdge;
-  sampler_desc.addressModeV = WGPUAddressMode_ClampToEdge;
-  sampler_desc.addressModeW = WGPUAddressMode_ClampToEdge;
-  sampler_desc.magFilter = WGPUFilterMode_Linear;
-  sampler_desc.minFilter = WGPUFilterMode_Linear;
-  sampler_desc.mipmapFilter = WGPUMipmapFilterMode_Nearest;
-  sampler_desc.maxAnisotropy = 1;
-  sampler_ = wgpuDeviceCreateSampler(ctx_.device, &sampler_desc);
+  pipeline_.set(create_post_process_pipeline_simple(
+      ctx_.device, WGPUTextureFormat_RGBA8Unorm, passthrough_shader_wgsl));
 }
 
-void PassthroughEffect::render(WGPUCommandEncoder encoder,
-                                 const UniformsSequenceParams& params,
-                                 NodeRegistry& nodes) {
+void Passthrough::render(WGPUCommandEncoder encoder,
+                         const UniformsSequenceParams& params,
+                         NodeRegistry& nodes) {
   // Get input/output views
   WGPUTextureView input_view = nodes.get_view(input_nodes_[0]);
   WGPUTextureView output_view = nodes.get_view(output_nodes_[0]);
@@ -44,7 +32,7 @@ void PassthroughEffect::render(WGPUCommandEncoder encoder,
   // Manually create bind group with only 3 entries (no effect params needed)
   WGPUBindGroupEntry entries[3] = {};
   entries[0].binding = PP_BINDING_SAMPLER;
-  entries[0].sampler = sampler_;
+  entries[0].sampler = sampler_.get();
   entries[1].binding = PP_BINDING_TEXTURE;
   entries[1].textureView = input_view;
   entries[2].binding = PP_BINDING_UNIFORMS;
@@ -52,32 +40,25 @@ void PassthroughEffect::render(WGPUCommandEncoder encoder,
   entries[2].size = sizeof(UniformsSequenceParams);
 
   WGPUBindGroupDescriptor bg_desc = {};
-  bg_desc.layout = wgpuRenderPipelineGetBindGroupLayout(pipeline_, 0);
+  bg_desc.layout = wgpuRenderPipelineGetBindGroupLayout(pipeline_.get(), 0);
   bg_desc.entryCount = 3;
   bg_desc.entries = entries;
 
-  if (bind_group_) {
-    wgpuBindGroupRelease(bind_group_);
-  }
-  bind_group_ = wgpuDeviceCreateBindGroup(ctx_.device, &bg_desc);
+  bind_group_.replace(wgpuDeviceCreateBindGroup(ctx_.device, &bg_desc));
 
   // Render pass
-  WGPURenderPassColorAttachment color_attachment = {
-    .view = output_view,
-    .depthSlice = WGPU_DEPTH_SLICE_UNDEFINED,
-    .loadOp = WGPULoadOp_Clear,
-    .storeOp = WGPUStoreOp_Store,
-    .clearValue = {0.0, 0.0, 0.0, 1.0}
-  };
+  WGPURenderPassColorAttachment color_attachment = {};
+  gpu_init_color_attachment(color_attachment, output_view);
 
   WGPURenderPassDescriptor pass_desc = {};
   pass_desc.colorAttachmentCount = 1;
   pass_desc.colorAttachments = &color_attachment;
 
-  WGPURenderPassEncoder pass = wgpuCommandEncoderBeginRenderPass(encoder, &pass_desc);
-  wgpuRenderPassEncoderSetPipeline(pass, pipeline_);
-  wgpuRenderPassEncoderSetBindGroup(pass, 0, bind_group_, 0, nullptr);
-  wgpuRenderPassEncoderDraw(pass, 3, 1, 0, 0);  // Fullscreen triangle
+  WGPURenderPassEncoder pass =
+      wgpuCommandEncoderBeginRenderPass(encoder, &pass_desc);
+  wgpuRenderPassEncoderSetPipeline(pass, pipeline_.get());
+  wgpuRenderPassEncoderSetBindGroup(pass, 0, bind_group_.get(), 0, nullptr);
+  wgpuRenderPassEncoderDraw(pass, 3, 1, 0, 0); // Fullscreen triangle
   wgpuRenderPassEncoderEnd(pass);
   wgpuRenderPassEncoderRelease(pass);
 }