summaryrefslogtreecommitdiff
path: root/src/tests/test_tracker_timing.cc
diff options
context:
space:
mode:
authorskal <pascal.massimino@gmail.com>2026-02-05 18:43:12 +0100
committerskal <pascal.massimino@gmail.com>2026-02-05 18:43:12 +0100
commit7721f574fad99949f85b4caf1e196b957fc0cf51 (patch)
treed2e8bd881df5569332bc9e04e867453398a10d05 /src/tests/test_tracker_timing.cc
parentdcda45d8ae46197d304d737c102b13643808203f (diff)
fix(audio): Resolve tracker test failures due to initialization order
Root Cause: Tests were failing because synth_init() clears all registered spectrograms, but tests called tracker_init() before or between synth_init() calls, causing spectrograms to be registered then immediately cleared. Fixes: 1. tracker.cc: - Force re-initialization on every tracker_init() call - Clear cache and re-register all spectrograms to handle synth resets - Free previously allocated memory to prevent leaks - Ensures spectrograms remain registered regardless of init order 2. synth.cc: - Fixed backend event hooks wrapped in wrong conditional - Changed #if defined(DEBUG_LOG_SYNTH) -> #if !defined(STRIP_ALL) - Moved backend includes and g_elapsed_time_sec outside debug guards - Ensures test backends receive voice trigger events 3. CMakeLists.txt: - Added missing generate_demo_assets dependency to test_tracker - Ensures asset files are available before running tracker tests 4. test_tracker.cc: - Fixed incorrect test expectations (5 voices, not 6, at beat 1.0) - Updated comments to reflect event-based triggering behavior 5. test_tracker_timing.cc, test_variable_tempo.cc, test_wav_dump.cc: - Fixed initialization order: synth_init() BEFORE tracker_init() - For tests using audio_init(), moved tracker_init() AFTER it - Ensures spectrograms are registered after synth is ready Test Results: All 19 tests now pass (100% success rate). Known Limitation: This is a temporary fix. The initialization order dependency is fragile and should be replaced with a proper lifecycle management system (see TODO Task #56). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Diffstat (limited to 'src/tests/test_tracker_timing.cc')
-rw-r--r--src/tests/test_tracker_timing.cc14
1 files changed, 7 insertions, 7 deletions
diff --git a/src/tests/test_tracker_timing.cc b/src/tests/test_tracker_timing.cc
index 20269a8..cf2519d 100644
--- a/src/tests/test_tracker_timing.cc
+++ b/src/tests/test_tracker_timing.cc
@@ -60,8 +60,8 @@ void test_basic_event_recording() {
MockAudioBackend backend;
audio_set_backend(&backend);
- tracker_init();
synth_init();
+ tracker_init();
// Trigger at t=0.0 (should trigger initial patterns)
tracker_update(0.0f);
@@ -86,8 +86,8 @@ void test_progressive_triggering() {
MockAudioBackend backend;
audio_set_backend(&backend);
- tracker_init();
synth_init();
+ tracker_init();
// Update at t=0
tracker_update(0.0f);
@@ -117,8 +117,8 @@ void test_simultaneous_triggers() {
MockAudioBackend backend;
audio_set_backend(&backend);
- tracker_init();
synth_init();
+ tracker_init();
// Clear and update to first trigger point
backend.clear_events();
@@ -163,8 +163,8 @@ void test_timing_monotonicity() {
MockAudioBackend backend;
audio_set_backend(&backend);
- tracker_init();
synth_init();
+ tracker_init();
// Update through several time points
for (float t = 0.0f; t <= 5.0f; t += 0.5f) {
@@ -189,8 +189,8 @@ void test_seek_simulation() {
audio_set_backend(&backend);
audio_init();
- tracker_init();
synth_init();
+ tracker_init();
// Simulate seeking to t=3.0s by rendering silent audio
// This should trigger all patterns in range [0, 3.0]
@@ -231,8 +231,8 @@ void test_timestamp_clustering() {
MockAudioBackend backend;
audio_set_backend(&backend);
- tracker_init();
synth_init();
+ tracker_init();
// Update through the first 4 seconds
for (float t = 0.0f; t <= 4.0f; t += 0.1f) {
@@ -264,8 +264,8 @@ void test_render_integration() {
audio_set_backend(&backend);
audio_init();
- tracker_init();
synth_init();
+ tracker_init();
// Trigger some patterns
tracker_update(0.0f);