fix(tests): port tests to v2 API, fix FATAL_CHECK logic

- Port test_effect_base to EffectV2/SequenceV2
- Port test_demo_effects to v2 effects only
- Remove v1 lifecycle helpers from effect_test_helpers
- Fix cnn_test to not depend on cnn_v1_effect.h
- Fix test_sequence_v2_e2e node redeclaration

Known issue: test_sequence_v2_e2e still fails with bind group error
(needs source/sink texture views set)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

1 files changed, 1 insertions, 17 deletions

diff --git a/src/tests/common/effect_test_helpers.h b/src/tests/common/effect_test_helpers.h
index 33355ee..962d1b0 100644
--- a/src/tests/common/effect_test_helpers.h
+++ b/src/tests/common/effect_test_helpers.h
@@ -1,6 +1,6 @@
 // This file is part of the 64k demo project.
 // It provides reusable test helpers for GPU effect testing.
-// Includes lifecycle helpers, pixel validation, and smoke tests.
+// Includes pixel validation utilities.
 
 #pragma once
 
@@ -8,10 +8,6 @@
 #include <functional>
 #include <vector>
 
-// Forward declarations
-class Effect;
-class MainSequence;
-
 // ============================================================================
 // Pixel Validation Helpers
 // ============================================================================
@@ -33,15 +29,3 @@ bool all_pixels_match_color(const std::vector<uint8_t>& pixels, int width,
 
 // Compute simple hash of pixel data (for deterministic output checks)
 uint64_t hash_pixels(const std::vector<uint8_t>& pixels);
-
-// ============================================================================
-// Effect Lifecycle Helpers
-// ============================================================================
-
-// Test that an effect can be constructed and initialized
-// Returns true if lifecycle succeeds, false otherwise
-bool test_effect_lifecycle(Effect* effect, MainSequence* main_seq);
-
-// Test that an effect can render without crashing (smoke test)
-// Does not validate output, only checks for crashes
-bool test_effect_render_smoke(Effect* effect);