summaryrefslogtreecommitdiff
path: root/src/gpu/wgsl_effect.cc
diff options
context:
space:
mode:
authorskal <pascal.massimino@gmail.com>2026-05-20 22:44:44 +0200
committerskal <pascal.massimino@gmail.com>2026-05-20 23:21:59 +0200
commita91f89c8ea15665853176c05597760d0fcf6e0df (patch)
treee403c16de7d44dff4f1bdb37ebb5c3186b191fcf /src/gpu/wgsl_effect.cc
parent5d20c892dedce7bc7486acbd72fbd35da69e413e (diff)
fix: code review cleanup — bugs, dead code, factorization, simplification
Bugs: - B1: fix dead tempo debug (prev_tempo captured after assignment) - B2: fix ReloadAssetsFromFile leak for disk-loaded assets; simplify DropAsset - B3: fix get_free_pool_slot leak (unregister synth + free data on reuse) - B4: volatile -> std::atomic with acquire/release in miniaudio_backend, synth - B5: fix unaligned reads in scene_loader (memcpy-based read_f32/read_u32) - B6: fix shader module + BGL + pipeline layout leaks in gpu.cc, pipeline_builder Dead code: - D1: remove unused particle_defs.h - D3: remove create_post_process_pipeline_simple (zero callers) - D4: remove empty gpu_draw() - D5: remove write-only Hybrid3D::initialized_ - D6: remove legacy pending buffer path in audio.cc Factorization: - F1: Effect::run_fullscreen_pass() replaces boilerplate in 5 effects - F2: particle_common.wgsl snippet, #include in 3 WGSL shaders - F3: gpu_create_shader_module() helper, used in 3 call sites - F5: get_world_aabb() shared between bvh.cc and physics.cc - F6: samples_to_seconds() replaces 6 inline expressions - F7: gpu_create_linear/nearest_sampler use SamplerCache; add nearest() preset Simplification: - S9+S1: WgslSamplerType param; Scene2Effect collapsed to thin wrapper - S4: FFT heap allocs -> stack arrays (zero allocs on hot path) - S5: ObjectType::CUBE documented as legacy alias for BOX; default changed - S6: bind group dirty-flag in Renderer3D; remove duplicate pipeline set - S7: create_gpu_procedural() helper in texture_manager (~80 lines removed) 37/37 tests passing. handoff(Claude): code review batch — all items verified, no regressions.
Diffstat (limited to 'src/gpu/wgsl_effect.cc')
-rw-r--r--src/gpu/wgsl_effect.cc8
1 files changed, 6 insertions, 2 deletions
diff --git a/src/gpu/wgsl_effect.cc b/src/gpu/wgsl_effect.cc
index 1cb0ecb..4f658a5 100644
--- a/src/gpu/wgsl_effect.cc
+++ b/src/gpu/wgsl_effect.cc
@@ -10,13 +10,17 @@ WgslEffect::WgslEffect(const GpuContext& ctx,
const std::vector<std::string>& outputs,
float start_time, float end_time,
const char* shader_code, WGPULoadOp load_op,
- WgslEffectParams initial_params)
+ WgslEffectParams initial_params,
+ WgslSamplerType sampler_type)
: Effect(ctx, inputs, outputs, start_time, end_time),
effect_params(initial_params),
load_op_(load_op) {
HEADLESS_RETURN_IF_NULL(ctx_.device);
- create_linear_sampler();
+ if (sampler_type == WgslSamplerType::Nearest)
+ create_nearest_sampler();
+ else
+ create_linear_sampler();
params_buffer_.init(ctx_.device);
pipeline_.set(create_post_process_pipeline(ctx_.device,