Refactor Effect class to centralize common uniforms management

Moved  to Effect base class. Updated all subclasses to use the base member, removing redundant declarations and initializations. Cleaned up  by removing redundant class definitions and including specific headers. Fixed a typo in DistortEffect constructor.

1 files changed, 2 insertions, 3 deletions

diff --git a/src/gpu/effects/theme_modulation_effect.cc b/src/gpu/effects/theme_modulation_effect.cc
index 7c222aa..b1eff90 100644
--- a/src/gpu/effects/theme_modulation_effect.cc
+++ b/src/gpu/effects/theme_modulation_effect.cc
@@ -67,14 +67,13 @@ ThemeModulationEffect::ThemeModulationEffect(const GpuContext& ctx)
   pipeline_ =
       create_post_process_pipeline(ctx_.device, ctx_.format, shader_code);
 
-  common_uniforms_.init(ctx_.device);
   params_buffer_ = gpu_create_buffer(
       ctx_.device, 16, WGPUBufferUsage_Uniform | WGPUBufferUsage_CopyDst);
 }
 
 void ThemeModulationEffect::update_bind_group(WGPUTextureView input_view) {
   pp_update_bind_group(ctx_.device, pipeline_, &bind_group_, input_view,
-                       common_uniforms_.get(), params_buffer_);
+                       uniforms_.get(), params_buffer_);
 }
 
 void ThemeModulationEffect::render(WGPURenderPassEncoder pass, float time,
@@ -87,7 +86,7 @@ void ThemeModulationEffect::render(WGPURenderPassEncoder pass, float time,
       .beat = beat,
       .audio_intensity = intensity,
   };
-  common_uniforms_.update(ctx_.queue, u);
+  uniforms_.update(ctx_.queue, u);
 
   // Alternate between bright and dark every 4 seconds (2 pattern changes)
   // Music patterns change every 2 seconds at 120 BPM