summaryrefslogtreecommitdiff
path: root/src/gpu/effects/circle_mask_effect.cc
diff options
context:
space:
mode:
authorskal <pascal.massimino@gmail.com>2026-02-11 11:46:53 +0100
committerskal <pascal.massimino@gmail.com>2026-02-11 11:46:53 +0100
commitc809790015b4ddc354c6b1993a633eddd042930f (patch)
treecb89e52e0c3b804b62544941e5cfc9b7d9ffc0c1 /src/gpu/effects/circle_mask_effect.cc
parent5fb1bcc25fef7388a2d68be6c1f062bcf996fd85 (diff)
refactor: Use lazy initialization for auxiliary textures
Prevents init/resize ordering bug and avoids unnecessary reallocation. Changes: - Auxiliary textures created on first use (compute/update_bind_group) - Added ensure_texture() methods to defer registration until resize() - Added early return in resize() if dimensions unchanged - Removed texture registration from init() methods Benefits: - No reallocation on window resize if dimensions match - Texture created with correct dimensions from start - Memory saved if effect never renders Tests: All 36 tests passing Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Diffstat (limited to 'src/gpu/effects/circle_mask_effect.cc')
-rw-r--r--src/gpu/effects/circle_mask_effect.cc19
1 files changed, 13 insertions, 6 deletions
diff --git a/src/gpu/effects/circle_mask_effect.cc b/src/gpu/effects/circle_mask_effect.cc
index aa9f324..08a9e33 100644
--- a/src/gpu/effects/circle_mask_effect.cc
+++ b/src/gpu/effects/circle_mask_effect.cc
@@ -26,11 +26,6 @@ CircleMaskEffect::~CircleMaskEffect() {
void CircleMaskEffect::init(MainSequence* demo) {
demo_ = demo;
- const uint32_t width = width_;
- const uint32_t height = height_;
-
- demo_->register_auxiliary_texture("circle_mask", width, height);
-
compute_params_.init(ctx_.device);
// Initialize uniforms BEFORE bind group creation
@@ -157,10 +152,20 @@ void CircleMaskEffect::init(MainSequence* demo) {
render_bind_group_ = wgpuDeviceCreateBindGroup(ctx_.device, &render_bg_desc);
}
+void CircleMaskEffect::ensure_texture() {
+ if (!texture_initialized_ && demo_) {
+ demo_->register_auxiliary_texture("circle_mask", width_, height_);
+ texture_initialized_ = true;
+ }
+}
+
void CircleMaskEffect::resize(int width, int height) {
+ if (width == width_ && height == height_)
+ return;
+
Effect::resize(width, height);
- if (!demo_)
+ if (!demo_ || !texture_initialized_)
return;
// Resize auxiliary texture
@@ -188,6 +193,8 @@ void CircleMaskEffect::resize(int width, int height) {
void CircleMaskEffect::compute(WGPUCommandEncoder encoder,
const CommonPostProcessUniforms& uniforms) {
+ ensure_texture();
+
uniforms_.update(ctx_.queue, uniforms);
const CircleMaskParams params = {