diff options
| author | skal <pascal.massimino@gmail.com> | 2026-02-17 11:00:51 +0100 |
|---|---|---|
| committer | skal <pascal.massimino@gmail.com> | 2026-02-17 11:00:51 +0100 |
| commit | a30a9878fe083240dbd98ae4ca93339cd8a8d667 (patch) | |
| tree | 169632773d7570f8847629d9177844b809cb4566 /src/effects/flash_effect.cc | |
| parent | a5e3e1bdb104555394e9f3aad6d1cf07e93998bf (diff) | |
fix(build): Resolve Windows cross-compilation failures
This commit fixes several issues that caused the Windows cross-compilation build (`scripts/build_win.sh`) to fail.
The root causes were platform-specific API differences in the wgpu-native library and incorrect dependency tracking in the CMake build system for generated code.
Changes:
- **`tools/seq_compiler.py`**: The timeline generator now wraps `depthSlice` assignments in `#if !defined(DEMO_CROSS_COMPILE_WIN32)` directives to handle API differences in `WGPURenderPassColorAttachment`.
- **`src/gpu/gpu.h`**: The `gpu_init_color_attachment` helper is now platform-aware, using a preprocessor guard for the `depthSlice` member.
- **`src/effects/*.cc`**: All effects are updated to use the new platform-aware helper or have explicit guards for `depthSlice`. Also, replaced `WGPUTexelCopyTextureInfo` with the cross-platform alias `GpuTextureCopyInfo` in `rotating_cube_effect.cc`.
- **`cmake`**: Added `tools/seq_compiler.py` as an explicit dependency to the `generate_timeline` and `generate_test_demo_timeline` custom commands. This ensures that changes to the generator script correctly trigger a rebuild of the generated C++ files.
- **`scripts/build_win.sh`**: Removed the erroneous attempt to build the `seq_compiler.py` script as a native executable.
With these changes, the Windows cross-compilation build now completes successfully.
Diffstat (limited to 'src/effects/flash_effect.cc')
| -rw-r--r-- | src/effects/flash_effect.cc | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/effects/flash_effect.cc b/src/effects/flash_effect.cc index c8638f0..7baf6a2 100644 --- a/src/effects/flash_effect.cc +++ b/src/effects/flash_effect.cc @@ -67,11 +67,7 @@ void Flash::render(WGPUCommandEncoder encoder, // Render pass WGPURenderPassColorAttachment color_attachment = {}; - color_attachment.view = output_view; - color_attachment.depthSlice = WGPU_DEPTH_SLICE_UNDEFINED; - color_attachment.loadOp = WGPULoadOp_Clear; - color_attachment.storeOp = WGPUStoreOp_Store; - color_attachment.clearValue = {0.0, 0.0, 0.0, 1.0}; + gpu_init_color_attachment(color_attachment, output_view); WGPURenderPassDescriptor pass_desc = {}; pass_desc.colorAttachmentCount = 1; |
