summaryrefslogtreecommitdiff
path: root/src/audio/audio_engine.h
diff options
context:
space:
mode:
authorskal <pascal.massimino@gmail.com>2026-03-26 10:09:34 +0100
committerskal <pascal.massimino@gmail.com>2026-03-26 10:09:34 +0100
commit8c5e41724fdfc3be24e95f48ae4b2be616404074 (patch)
tree052d8512b43ff4d41af66d71f5fa8dc7de0f609a /src/audio/audio_engine.h
parent26627e8b9fee3fb3b2ec6314fc5cf45620769fcb (diff)
fix(audio): P1-P3 fixes from audio code reviewHEADmain
P1 — correctness bugs: - tracker.cc: move delete[] loop before pool reset so guard condition is valid - audio_engine: replace tracker_reset() with tracker_init() in reset()/seek() so synth IDs are re-registered after synth_init() clears spectrogram slots - spectrogram_resource_manager: set spec.version in load_procedural() (was UB) P2 — minor bugs: - synth.cc: move pan clamp unconditionally before debug-only block - gen.cc: remove dead `freq` variable in generate_note_spectrogram() - tracker.cc: remove duplicate g_sample_synth_cache clear loop P3 — cleanup: - Replace hardcoded 32000.0f with RING_BUFFER_SAMPLE_RATE (5 sites) - audio.cc: extract clip_samples() helper, remove duplicated clip loops - audio_engine: inline update_silent(), remove no-op prewarm_for_time_range() - Remove stale comments: stdio.h include, NEW: labels, CACHING block, NOTE: - Move TODO(timing) drift notes from source to TODO.md handoff(Gemini): audio review implemented, 36/36 tests passing
Diffstat (limited to 'src/audio/audio_engine.h')
-rw-r--r--src/audio/audio_engine.h9
1 files changed, 0 insertions, 9 deletions
diff --git a/src/audio/audio_engine.h b/src/audio/audio_engine.h
index 699213d..cc4c80a 100644
--- a/src/audio/audio_engine.h
+++ b/src/audio/audio_engine.h
@@ -50,17 +50,8 @@ class AudioEngine {
// Get or create synth ID for a sample
int get_or_register_synth_id(int sample_id);
-#if !defined(STRIP_ALL)
- // Seeking support
- void prewarm_for_time_range(float start_time, float end_time);
- void update_silent(float music_time); // Update without triggering audio
-#endif
-
SpectrogramResourceManager resource_mgr_;
- // NOTE: For now, synth and tracker are global C functions (not members)
- // Future refactoring will convert them to member objects
-
// Mapping: sample_id → synth_id (lazy registration)
int sample_to_synth_id_[MAX_SPECTROGRAM_RESOURCES];