summaryrefslogtreecommitdiff
path: root/doc/BUILD_OPTIMIZATION_PROPOSAL_V2.md
diff options
context:
space:
mode:
authorskal <pascal.massimino@gmail.com>2026-02-07 10:17:18 +0100
committerskal <pascal.massimino@gmail.com>2026-02-07 10:17:18 +0100
commit2cadafb2821ca46bd29dd82ef718302472f2eff3 (patch)
tree23cc1c0491861f77b277b366c61ce36f3598919a /doc/BUILD_OPTIMIZATION_PROPOSAL_V2.md
parent4800e062e8ca38909ef85695ffbecc32a9d88799 (diff)
fix(ci): Update verification script to catch tool compilation failures
Problem: The spectool.cc include path bug was not caught by the test suite because check_all.sh only built tests, not tools. Root Cause Analysis: - check_all.sh used -DDEMO_BUILD_TESTS=ON only - Tools (spectool, specview, specplay) are built with -DDEMO_BUILD_TOOLS=ON - CTest runs tests but doesn't verify tool compilation - Result: Tool compilation failures went undetected Solution: Updated scripts/check_all.sh to: 1. Enable both -DDEMO_BUILD_TESTS=ON and -DDEMO_BUILD_TOOLS=ON 2. Explicitly verify all tools compile (spectool, specview, specplay) 3. Add clear output messages for each verification stage 4. Document what the script verifies in header comments Updated doc/CONTRIBUTING.md: - Added "Automated Verification (Recommended)" section - Documented that check_all.sh verifies tests AND tools - Provided manual verification steps as alternative - Clear command examples with expected behavior Verification: - Tested by intentionally breaking spectool.cc include - Script correctly caught the compilation error - Reverted break and verified all tools build successfully This ensures all future tool changes are verified before commit. Prevents regression: Similar include path issues will now be caught by pre-commit verification.
Diffstat (limited to 'doc/BUILD_OPTIMIZATION_PROPOSAL_V2.md')
0 files changed, 0 insertions, 0 deletions