diff options
| author | skal <pascal.massimino@gmail.com> | 2026-03-21 14:01:30 +0100 |
|---|---|---|
| committer | skal <pascal.massimino@gmail.com> | 2026-03-21 14:01:30 +0100 |
| commit | bf33fee131b1eee03bc5a765ba360299bbcead06 (patch) | |
| tree | b6a076ec977bb250a13b6a69be1092a183ae18ce /cnn_v3/shaders/cnn_v3_bottleneck.wgsl | |
| parent | 35355b17576e93b035a2a78ecd05771e98f068ee (diff) | |
refactor(cnn_v3): code review — comments, simplifications, test fix
C++:
- cnn_v3_effect.cc: fix declare_nodes comment (output node declared by caller)
- cnn_v3_effect.cc: add TODO(phase-7) marker for FiLM MLP replacement
WGSL:
- cnn_v3_bottleneck.wgsl: consolidate _pad fields onto one line, explain why
array<u32,3> is invalid in uniform address space
- cnn_v3_enc0.wgsl: fix "12xu8" → "12ch u8norm" in header comment
- cnn_v3_dec0.wgsl: clarify parity note (sigmoid after FiLM+ReLU, not raw conv)
- cnn_v3_common.wgsl: clarify unpack_8ch pack layout (low/high 16 bits)
Python:
- cnn_v3_utils.py: replace PIL-based _upsample_nearest (uint8 round-trip) with
pure numpy index arithmetic; rename _resize_rgb → _resize_img (handles any
channel count); add comment on normal zero-pad workaround
- export_cnn_v3_weights.py: add cross-ref to cnn_v3_effect.cc constants;
clarify weight count comments with Conv notation
Test:
- test_cnn_v3_parity.cc: enc0/dec1 layer failures now return 0 (were print-only)
handoff(Gemini): CNN v3 review complete, 36/36 tests passing.
Diffstat (limited to 'cnn_v3/shaders/cnn_v3_bottleneck.wgsl')
| -rw-r--r-- | cnn_v3/shaders/cnn_v3_bottleneck.wgsl | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/cnn_v3/shaders/cnn_v3_bottleneck.wgsl b/cnn_v3/shaders/cnn_v3_bottleneck.wgsl index 909fd41..e24586f 100644 --- a/cnn_v3/shaders/cnn_v3_bottleneck.wgsl +++ b/cnn_v3/shaders/cnn_v3_bottleneck.wgsl @@ -15,9 +15,7 @@ const BN_OUT: u32 = 8u; struct Params { weight_offset: u32, - _pad0: u32, - _pad1: u32, - _pad2: u32, + _pad0: u32, _pad1: u32, _pad2: u32, // 3 explicit pads: array<u32,3> invalid in uniform } @group(0) @binding(0) var enc1_tex: texture_2d<u32>; |
