From e2c3c3e95b6a9e53b4631b271640bb9914f8c95e Mon Sep 17 00:00:00 2001 From: skal Date: Thu, 5 Mar 2026 10:03:32 +0100 Subject: fix(audio): OLA encoder never ran; version never propagated to decoder MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two bugs kept the v2 OLA path permanently disabled: 1. SpectrogramResourceManager::load_asset() never set spec.version from SpecHeader::version — all .spec assets loaded with version=0, so ola_mode was always false in the voice. 2. spectool analyze_audio() used non-overlapping chunks (stride=DCT_SIZE), hamming_window_512, and hardcoded header.version=1 — OLA analysis was never implemented in the encoder. Fixes: propagate header->version in load_asset(); switch spectool to OLA_HOP_SIZE stride, hann_window_512, and SPEC_VERSION_V2_OLA. Regenerated all .spec files. handoff(Gemini): OLA enc/dec chain now correct end-to-end. .spec files are v2 (50% overlap, Hann). No API changes; 33/34 tests pass (WavDumpBackendTest pre-existing failure unrelated). Co-Authored-By: Claude Sonnet 4.6 --- workspaces/main/music/BASS_GUITAR_FEEL.spec | Bin 51216 -> 98320 bytes workspaces/main/music/BASS_SYNTH_1.spec | Bin 32784 -> 61456 bytes workspaces/main/music/CLARINET_COUGH.spec | Bin 387088 -> 768016 bytes workspaces/main/music/CRASH_DMX.spec | Bin 217104 -> 432144 bytes workspaces/main/music/HIHAT_CLOSED_DMX.spec | Bin 20496 -> 36880 bytes workspaces/main/music/HIHAT_CLOSED_DUFF.spec | Bin 12304 -> 22544 bytes workspaces/main/music/HIHAT_CLOSED_ER_1.spec | Bin 16400 -> 28688 bytes workspaces/main/music/KICK_606.spec | Bin 139280 -> 272400 bytes workspaces/main/music/KICK_90S_2.spec | Bin 30736 -> 57360 bytes workspaces/main/music/RIDE_CUP_1.spec | Bin 3577872 -> 7151632 bytes workspaces/main/music/SNARE_808.spec | Bin 120848 -> 235536 bytes workspaces/main/music/SNARE_909_TUNE_8.spec | Bin 43024 -> 79888 bytes workspaces/main/music/SNARE_BLUE_ROOM.spec | Bin 43024 -> 81936 bytes workspaces/main/music/SPLASH_GROUNDED.spec | Bin 57360 -> 110608 bytes workspaces/main/music/SYNTH_BASS_DISTORT.spec | Bin 32784 -> 61456 bytes 15 files changed, 0 insertions(+), 0 deletions(-) (limited to 'workspaces/main/music') diff --git a/workspaces/main/music/BASS_GUITAR_FEEL.spec b/workspaces/main/music/BASS_GUITAR_FEEL.spec index 54f49a6..2521025 100644 Binary files a/workspaces/main/music/BASS_GUITAR_FEEL.spec and b/workspaces/main/music/BASS_GUITAR_FEEL.spec differ diff --git a/workspaces/main/music/BASS_SYNTH_1.spec b/workspaces/main/music/BASS_SYNTH_1.spec index 33bc0a0..9a3f585 100644 Binary files a/workspaces/main/music/BASS_SYNTH_1.spec and b/workspaces/main/music/BASS_SYNTH_1.spec differ diff --git a/workspaces/main/music/CLARINET_COUGH.spec b/workspaces/main/music/CLARINET_COUGH.spec index a2b1657..f41ff4a 100644 Binary files a/workspaces/main/music/CLARINET_COUGH.spec and b/workspaces/main/music/CLARINET_COUGH.spec differ diff --git a/workspaces/main/music/CRASH_DMX.spec b/workspaces/main/music/CRASH_DMX.spec index 45ee52d..fc36694 100644 Binary files a/workspaces/main/music/CRASH_DMX.spec and b/workspaces/main/music/CRASH_DMX.spec differ diff --git a/workspaces/main/music/HIHAT_CLOSED_DMX.spec b/workspaces/main/music/HIHAT_CLOSED_DMX.spec index 8fce1d2..655b0f9 100644 Binary files a/workspaces/main/music/HIHAT_CLOSED_DMX.spec and b/workspaces/main/music/HIHAT_CLOSED_DMX.spec differ diff --git a/workspaces/main/music/HIHAT_CLOSED_DUFF.spec b/workspaces/main/music/HIHAT_CLOSED_DUFF.spec index f738271..3042a42 100644 Binary files a/workspaces/main/music/HIHAT_CLOSED_DUFF.spec and b/workspaces/main/music/HIHAT_CLOSED_DUFF.spec differ diff --git a/workspaces/main/music/HIHAT_CLOSED_ER_1.spec b/workspaces/main/music/HIHAT_CLOSED_ER_1.spec index bb03f5e..ac780f2 100644 Binary files a/workspaces/main/music/HIHAT_CLOSED_ER_1.spec and b/workspaces/main/music/HIHAT_CLOSED_ER_1.spec differ diff --git a/workspaces/main/music/KICK_606.spec b/workspaces/main/music/KICK_606.spec index 10af84a..68f5f74 100644 Binary files a/workspaces/main/music/KICK_606.spec and b/workspaces/main/music/KICK_606.spec differ diff --git a/workspaces/main/music/KICK_90S_2.spec b/workspaces/main/music/KICK_90S_2.spec index 126409e..91a9c34 100644 Binary files a/workspaces/main/music/KICK_90S_2.spec and b/workspaces/main/music/KICK_90S_2.spec differ diff --git a/workspaces/main/music/RIDE_CUP_1.spec b/workspaces/main/music/RIDE_CUP_1.spec index 78867c1..b0fed88 100644 Binary files a/workspaces/main/music/RIDE_CUP_1.spec and b/workspaces/main/music/RIDE_CUP_1.spec differ diff --git a/workspaces/main/music/SNARE_808.spec b/workspaces/main/music/SNARE_808.spec index 2923c3c..bc77d85 100644 Binary files a/workspaces/main/music/SNARE_808.spec and b/workspaces/main/music/SNARE_808.spec differ diff --git a/workspaces/main/music/SNARE_909_TUNE_8.spec b/workspaces/main/music/SNARE_909_TUNE_8.spec index 4693c05..3f38ca6 100644 Binary files a/workspaces/main/music/SNARE_909_TUNE_8.spec and b/workspaces/main/music/SNARE_909_TUNE_8.spec differ diff --git a/workspaces/main/music/SNARE_BLUE_ROOM.spec b/workspaces/main/music/SNARE_BLUE_ROOM.spec index b24baa7..3d489dd 100644 Binary files a/workspaces/main/music/SNARE_BLUE_ROOM.spec and b/workspaces/main/music/SNARE_BLUE_ROOM.spec differ diff --git a/workspaces/main/music/SPLASH_GROUNDED.spec b/workspaces/main/music/SPLASH_GROUNDED.spec index a919be4..210a784 100644 Binary files a/workspaces/main/music/SPLASH_GROUNDED.spec and b/workspaces/main/music/SPLASH_GROUNDED.spec differ diff --git a/workspaces/main/music/SYNTH_BASS_DISTORT.spec b/workspaces/main/music/SYNTH_BASS_DISTORT.spec index 33bc0a0..9a3f585 100644 Binary files a/workspaces/main/music/SYNTH_BASS_DISTORT.spec and b/workspaces/main/music/SYNTH_BASS_DISTORT.spec differ -- cgit v1.2.3