From dd9d3013d260f27f86b268c203a290f91431d8e5 Mon Sep 17 00:00:00 2001 From: skal Date: Wed, 4 Feb 2026 22:08:56 +0100 Subject: feat: Optional sequence end times and comprehensive effect documentation This milestone implements several key enhancements to the sequencing system and developer documentation: ## Optional Sequence End Times (New Feature) - Added support for explicit sequence termination via [time] syntax - Example: SEQUENCE 0 0 [30.0] forcefully ends all effects at 30 seconds - Updated seq_compiler.cc to parse optional [time] parameter with brackets - Added end_time_ field to Sequence class (default -1.0 = no explicit end) - Modified update_active_list() to check sequence end time and deactivate all effects when reached - Fully backward compatible - existing sequences work unchanged ## Comprehensive Effect Documentation (demo.seq) - Documented all effect constructor parameters (standard: device, queue, format) - Added runtime parameter documentation (time, beat, intensity, aspect_ratio) - Created detailed effect catalog with specific behaviors: * Scene effects: HeptagonEffect, ParticlesEffect, Hybrid3DEffect, FlashCubeEffect * Post-process effects: GaussianBlurEffect, SolarizeEffect, ChromaAberrationEffect, ThemeModulationEffect, FadeEffect, FlashEffect - Added examples section showing common usage patterns - Documented exact parameter behaviors (e.g., blur pulsates 0.5x-2.5x, flash triggers at intensity > 0.7, theme cycles every 8 seconds) ## Code Quality & Verification - Audited all hardcoded 1280x720 dimensions throughout codebase - Verified all shaders use uniforms.resolution and uniforms.aspect_ratio - Confirmed Effect::resize() properly updates width_/height_ members - No issues found - dimension handling is fully dynamic and robust ## Files Changed - tools/seq_compiler.cc: Parse [end_time], generate set_end_time() calls - src/gpu/effect.h: Added end_time_, set_end_time(), get_end_time() - src/gpu/effect.cc: Check sequence end time in update_active_list() - assets/demo.seq: Comprehensive syntax and effect documentation - Generated files updated (timeline.cc, assets_data.cc, music_data.cc) This work establishes a more flexible sequencing system and provides developers with clear documentation for authoring demo timelines. handoff(Claude): Optional sequence end times implemented, effect documentation complete, dimension handling verified. Ready for next phase of development. --- tools/spectool.cc | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'tools/spectool.cc') diff --git a/tools/spectool.cc b/tools/spectool.cc index 1dd4ceb..7349912 100644 --- a/tools/spectool.cc +++ b/tools/spectool.cc @@ -29,7 +29,15 @@ int analyze_audio(const char* in_path, const char* out_path) { printf("Analyzing %s -> %s\n", in_path, out_path); + // Use higher quality resampling for better audio quality + // Source files are typically 44.1kHz or 96kHz, 16/24-bit, mono/stereo ma_decoder_config config = ma_decoder_config_init(ma_format_f32, 1, 32000); + + // CRITICAL: Use highest quality low-pass filter to preserve audio quality + // Default lpfOrder is very low, causing audible aliasing when downsampling + // Maximum lpfOrder is implementation-dependent, but 8 is reasonable for quality + config.resampling.linear.lpfOrder = 8; // Higher = better anti-aliasing (default is likely 1-2) + ma_decoder decoder; if (ma_decoder_init_file(in_path, &config, &decoder) != MA_SUCCESS) { printf("Error: Failed to open or decode audio file: %s\n", in_path); -- cgit v1.2.3