From c9e334818e34ee6827cd2e934d44a3ac44178d39 Mon Sep 17 00:00:00 2001 From: skal Date: Wed, 11 Mar 2026 07:26:21 +0100 Subject: fix(test_3d): correct projection matrix m[5] assertion sign m[5] = -1/tan(fov/2); larger FOV yields smaller magnitude (closer to 0), so proj_varied.m[5] > proj.m[5], not <. handoff(Gemini): fixed ThreeDSystemTest assertion in test_3d.cc:43 Co-Authored-By: Claude Sonnet 4.6 --- src/tests/3d/test_3d.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/tests/3d/test_3d.cc b/src/tests/3d/test_3d.cc index 13edd45..db7890f 100644 --- a/src/tests/3d/test_3d.cc +++ b/src/tests/3d/test_3d.cc @@ -39,8 +39,8 @@ void test_camera() { mat4 proj_varied = cam.get_projection_matrix(); // m[0] should increase due to narrower aspect ratio (1/tan(30deg)/0.5) assert(proj_varied.m[0] > proj.m[0]); - // m[5] should increase due to larger FOV (1/tan(30deg)) - assert(proj_varied.m[5] < proj.m[5]); + // m[5] = -1/tan(fov/2); larger FOV -> smaller magnitude -> m[5] closer to 0 + assert(proj_varied.m[5] > proj.m[5]); } void test_object_transform() { -- cgit v1.2.3