From 8da917bce6e937ab092bb2f68c0bcf6039c3a3d7 Mon Sep 17 00:00:00 2001
From: skal <pascal.massimino@gmail.com>
Date: Wed, 4 Feb 2026 10:37:37 +0100
Subject: test(procedural): Improve test coverage (Task #45)

Added tests for gen_perlin and make_periodic. Improved parameter handling checks. Coverage for src/procedural/generator.cc increased to 96%.
---
 src/tests/test_procedural.cc | 96 +++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 91 insertions(+), 5 deletions(-)

(limited to 'src')

diff --git a/src/tests/test_procedural.cc b/src/tests/test_procedural.cc
index 3b82fa0..0373402 100644
--- a/src/tests/test_procedural.cc
+++ b/src/tests/test_procedural.cc
@@ -5,6 +5,7 @@
 #include <cassert>
 #include <iostream>
 #include <vector>
+#include <cmath>
 
 void test_noise() {
   std::cout << "Testing Noise Generator..." << std::endl;
@@ -12,11 +13,40 @@ void test_noise() {
   std::vector<uint8_t> buffer(w * h * 4);
   float params[] = {12345, 1.0f}; // Seed, Intensity
 
-  procedural::gen_noise(buffer.data(), w, h, params, 2);
+  // Test with explicit params
+  bool res = procedural::gen_noise(buffer.data(), w, h, params, 2);
+  assert(res);
+  assert(buffer[3] == 255);
+  
+  // Check that not all pixels are black
+  bool nonzero = false;
+  for (size_t i = 0; i < buffer.size(); i += 4) {
+    if (buffer[i] > 0) {
+      nonzero = true;
+      break;
+    }
+  }
+  assert(nonzero);
+
+  // Test with default params
+  std::fill(buffer.begin(), buffer.end(), 0);
+  res = procedural::gen_noise(buffer.data(), w, h, nullptr, 0);
+  assert(res);
+  assert(buffer[3] == 255); // Alpha should still be set
+}
 
-  // Check simple properties: alpha should be 255
+void test_perlin() {
+  std::cout << "Testing Perlin Generator..." << std::endl;
+  int w = 64, h = 64;
+  std::vector<uint8_t> buffer(w * h * 4);
+  
+  // Test with explicit params
+  // Params: Seed, Freq, Amp, Decay, Octaves
+  float params[] = {12345, 4.0f, 1.0f, 0.5f, 4.0f};
+  bool res = procedural::gen_perlin(buffer.data(), w, h, params, 5);
+  assert(res);
   assert(buffer[3] == 255);
-  // Check that not all pixels are black (very unlikely with noise)
+
   bool nonzero = false;
   for (size_t i = 0; i < buffer.size(); i += 4) {
     if (buffer[i] > 0) {
@@ -25,6 +55,16 @@ void test_noise() {
     }
   }
   assert(nonzero);
+
+  // Test with default params
+  std::fill(buffer.begin(), buffer.end(), 0);
+  res = procedural::gen_perlin(buffer.data(), w, h, nullptr, 0);
+  assert(res);
+  assert(buffer[3] == 255);
+
+  // Test memory allocation failure simulation (large dimensions)
+  // This is hard to robustly test without mocking, but we can try an excessively large allocation if desired.
+  // For now, we trust the logic path.
 }
 
 void test_grid() {
@@ -33,7 +73,9 @@ void test_grid() {
   std::vector<uint8_t> buffer(w * h * 4);
   float params[] = {10, 1}; // Size 10, Thickness 1
 
-  procedural::gen_grid(buffer.data(), w, h, params, 2);
+  // Test with explicit params
+  bool res = procedural::gen_grid(buffer.data(), w, h, params, 2);
+  assert(res);
 
   // Pixel (0,0) should be white (on line)
   assert(buffer[0] == 255);
@@ -41,11 +83,55 @@ void test_grid() {
   assert(buffer[(5 * w + 5) * 4] == 0);
   // Pixel (10,0) should be white (on vertical line)
   assert(buffer[(0 * w + 10) * 4] == 255);
+
+  // Test with default params
+  res = procedural::gen_grid(buffer.data(), w, h, nullptr, 0);
+  assert(res);
+  // Default size is 32, thickness 2
+  assert(buffer[0] == 255);
+  assert(buffer[(0 * w + 32) * 4] == 255);
+}
+
+void test_periodic() {
+  std::cout << "Testing Periodic Blending..." << std::endl;
+  int w = 64, h = 64;
+  std::vector<uint8_t> buffer(w * h * 4);
+
+  // Fill with horizontal gradient: left=0, right=255
+  for(int y=0; y<h; ++y) {
+    for(int x=0; x<w; ++x) {
+        int idx = (y*w + x) * 4;
+        buffer[idx] = (uint8_t)(x * 255 / (w-1));
+        buffer[idx+1] = 0;
+        buffer[idx+2] = 0;
+        buffer[idx+3] = 255;
+    }
+  }
+
+  // Pre-check: edges are different
+  assert(buffer[0] == 0);
+  assert(buffer[(w-1)*4] == 255);
+
+  float params[] = {0.1f}; // Blend ratio 10%
+  bool res = procedural::make_periodic(buffer.data(), w, h, params, 1);
+  assert(res);
+
+  // Post-check: Left edge (x=0) should now be blended with right edge.
+  // Logic: blend right edge INTO left edge. At x=0, we copy from right side.
+  // So buffer[0] should be close to 255 (value from right).
+  assert(buffer[0] > 200); 
+
+  // Check invalid ratio
+  float invalid_params[] = { -1.0f };
+  res = procedural::make_periodic(buffer.data(), w, h, invalid_params, 1);
+  assert(res); // Should return true but do nothing
 }
 
 int main() {
   test_noise();
+  test_perlin();
   test_grid();
+  test_periodic();
   std::cout << "--- PROCEDURAL TESTS PASSED ---" << std::endl;
   return 0;
-}
+}
\ No newline at end of file
-- 
cgit v1.2.3