From d378da77eec4d506bc01e4c08c38644d72969cc7 Mon Sep 17 00:00:00 2001
From: skal <pascal.massimino@gmail.com>
Date: Wed, 11 Feb 2026 11:34:08 +0100
Subject: refactor: Simplify effect render API and fix uniform initialization
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Root cause: Uniform buffers created but not initialized before bind group
creation, causing undefined UV coordinates in circle_mask_compute.wgsl.

Changes:
- Add get_common_uniforms() helper to Effect base class
- Refactor render()/compute() signatures: 5 params → CommonPostProcessUniforms&
- Fix uninitialized uniforms in CircleMaskEffect and CNNEffect
- Update all 19 effect implementations and headers
- Fix WGSL syntax error in FlashEffect (u.audio_intensity → audio_intensity)
- Update test files (test_sequence.cc)

Benefits:
- Cleaner API: construct uniforms once per frame, reuse across effects
- More maintainable: CommonPostProcessUniforms changes need no call site updates
- Fixes UV coordinate bug in circle_mask_compute.wgsl

All 36 tests passing (100%)

handoff(Claude): Effect API refactor complete
---
 src/tests/assets/test_sequence.cc | 27 +++++++++------------------
 1 file changed, 9 insertions(+), 18 deletions(-)

(limited to 'src/tests')

diff --git a/src/tests/assets/test_sequence.cc b/src/tests/assets/test_sequence.cc
index d79ec1d..44aac46 100644
--- a/src/tests/assets/test_sequence.cc
+++ b/src/tests/assets/test_sequence.cc
@@ -38,22 +38,16 @@ class DummyEffect : public Effect {
   void start() override {
     ++start_calls;
   }
-  void render(WGPURenderPassEncoder pass, float time, float beat,
-              float intensity, float aspect_ratio) override {
+  void render(WGPURenderPassEncoder pass,
+              const CommonPostProcessUniforms& uniforms) override {
     ++render_calls;
     (void)pass;
-    (void)time;
-    (void)beat;
-    (void)intensity;
-    (void)aspect_ratio;
+    (void)uniforms;
   }
-  void compute(WGPUCommandEncoder encoder, float time, float beat,
-               float intensity, float aspect_ratio) override {
+  void compute(WGPUCommandEncoder encoder,
+               const CommonPostProcessUniforms& uniforms) override {
     (void)encoder;
-    (void)time;
-    (void)beat;
-    (void)intensity;
-    (void)aspect_ratio;
+    (void)uniforms;
   }
   void end() override {
     ++end_calls;
@@ -77,14 +71,11 @@ class DummyPostProcessEffect : public PostProcessEffect {
     ++init_calls;
     (void)demo;
   }
-  void render(WGPURenderPassEncoder pass, float time, float beat,
-              float intensity, float aspect_ratio) override {
+  void render(WGPURenderPassEncoder pass,
+              const CommonPostProcessUniforms& uniforms) override {
     ++render_calls;
     (void)pass;
-    (void)time;
-    (void)beat;
-    (void)intensity;
-    (void)aspect_ratio;
+    (void)uniforms;
   }
   void update_bind_group(WGPUTextureView input_view) override {
     ++update_bind_group_calls;
-- 
cgit v1.2.3