From 7721f574fad99949f85b4caf1e196b957fc0cf51 Mon Sep 17 00:00:00 2001 From: skal Date: Thu, 5 Feb 2026 18:43:12 +0100 Subject: fix(audio): Resolve tracker test failures due to initialization order Root Cause: Tests were failing because synth_init() clears all registered spectrograms, but tests called tracker_init() before or between synth_init() calls, causing spectrograms to be registered then immediately cleared. Fixes: 1. tracker.cc: - Force re-initialization on every tracker_init() call - Clear cache and re-register all spectrograms to handle synth resets - Free previously allocated memory to prevent leaks - Ensures spectrograms remain registered regardless of init order 2. synth.cc: - Fixed backend event hooks wrapped in wrong conditional - Changed #if defined(DEBUG_LOG_SYNTH) -> #if !defined(STRIP_ALL) - Moved backend includes and g_elapsed_time_sec outside debug guards - Ensures test backends receive voice trigger events 3. CMakeLists.txt: - Added missing generate_demo_assets dependency to test_tracker - Ensures asset files are available before running tracker tests 4. test_tracker.cc: - Fixed incorrect test expectations (5 voices, not 6, at beat 1.0) - Updated comments to reflect event-based triggering behavior 5. test_tracker_timing.cc, test_variable_tempo.cc, test_wav_dump.cc: - Fixed initialization order: synth_init() BEFORE tracker_init() - For tests using audio_init(), moved tracker_init() AFTER it - Ensures spectrograms are registered after synth is ready Test Results: All 19 tests now pass (100% success rate). Known Limitation: This is a temporary fix. The initialization order dependency is fragile and should be replaced with a proper lifecycle management system (see TODO Task #56). Co-Authored-By: Claude Sonnet 4.5 --- src/tests/test_wav_dump.cc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/tests/test_wav_dump.cc') diff --git a/src/tests/test_wav_dump.cc b/src/tests/test_wav_dump.cc index 7d3dbf6..753d548 100644 --- a/src/tests/test_wav_dump.cc +++ b/src/tests/test_wav_dump.cc @@ -33,18 +33,17 @@ void test_wav_format_matches_live_audio() { const char* test_file = "test_format.wav"; - // Initialize audio system - synth_init(); - tracker_init(); - // Create WAV dump backend WavDumpBackend wav_backend; wav_backend.set_output_file(test_file); audio_set_backend(&wav_backend); - // Initialize and render 1 second of audio + // Initialize audio system (calls synth_init internally) audio_init(); + // Initialize tracker AFTER audio_init to ensure spectrograms stay registered + tracker_init(); + // Manually trigger some audio for testing tracker_update(0.0f); // Trigger patterns at t=0 -- cgit v1.2.3