From 8296fe5180b979b9d1f32f6375b41f0e0a8a399d Mon Sep 17 00:00:00 2001 From: skal Date: Sun, 8 Feb 2026 17:39:33 +0100 Subject: feat(gpu): Add parameter-driven ChromaAberrationEffect MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Implements Task #73 - Extends shader parametrization system to ChromaAberrationEffect following the FlashEffect pattern. Changes: - Added ChromaAberrationParams struct (offset_scale, angle) - Added ChromaUniforms with proper WGSL alignment (32 bytes) - Updated shader to compute offset direction from angle parameter - Extended seq_compiler to parse offset/angle parameters - Updated demo.seq with 2 parameterized instances: * Line 50: offset=0.03 angle=0.785 (45° diagonal, stronger) * Line 76: offset=0.01 angle=1.57 (90° vertical, subtle) Technical details: - Backward-compatible default constructor maintained - Migrated from raw buffer to UniformBuffer - Shader computes direction: vec2(cos(angle), sin(angle)) - Generated code creates ChromaAberrationParams initialization Testing: - All 32/32 tests pass - Demo runs without errors - Binary size: 5.6M stripped (~200-300 bytes impact) Co-Authored-By: Claude Sonnet 4.5 --- src/tests/test_effect_base.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/tests/test_effect_base.cc') diff --git a/src/tests/test_effect_base.cc b/src/tests/test_effect_base.cc index 2534b36..e280e05 100644 --- a/src/tests/test_effect_base.cc +++ b/src/tests/test_effect_base.cc @@ -60,10 +60,12 @@ static void test_offscreen_render_target() { // Note: Buffer mapping may fail on some systems (WebGPU driver issue) // Don't fail the test if readback returns empty buffer if (pixels.empty()) { - fprintf(stdout, " ⚠ Pixel readback skipped (buffer mapping unavailable)\n"); + fprintf(stdout, + " ⚠ Pixel readback skipped (buffer mapping unavailable)\n"); } else { assert(pixels.size() == 256 * 256 * 4 && "Pixel buffer size should match"); - fprintf(stdout, " ✓ Pixel readback succeeded (%zu bytes)\n", pixels.size()); + fprintf(stdout, " ✓ Pixel readback succeeded (%zu bytes)\n", + pixels.size()); } } -- cgit v1.2.3