From df39c7e3efa70376fac579b178c803eb319d517f Mon Sep 17 00:00:00 2001
From: skal <pascal.massimino@gmail.com>
Date: Mon, 9 Feb 2026 09:49:51 +0100
Subject: fix: Resolve WebGPU uniform buffer alignment issues (Task #74)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixed critical validation errors caused by WGSL vec3<f32> alignment mismatches.

Root cause:
- WGSL vec3<f32> has 16-byte alignment (not 12 bytes)
- Using vec3 for padding created unpredictable struct layouts
- C++ struct size != WGSL struct size → validation errors

Solution:
- Changed circle_mask_compute.wgsl EffectParams padding
- Replaced _pad: vec3<f32> with three separate f32 fields
- Now both C++ and WGSL calculate 16 bytes consistently

Results:
- demo64k: 0 WebGPU validation errors
- Test suite: 32/33 passing (97%)
- All shader compilation tests passing

Files modified:
- assets/final/shaders/circle_mask_compute.wgsl
- TODO.md (updated task status)
- PROJECT_CONTEXT.md (updated test results)
- HANDOFF_2026-02-09_UniformAlignment.md (technical writeup)

Note: DemoEffectsTest failure is unrelated (wgpu_native library bug)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
---
 src/tests/test_demo_effects.cc | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

(limited to 'src/tests/test_demo_effects.cc')

diff --git a/src/tests/test_demo_effects.cc b/src/tests/test_demo_effects.cc
index e6b794b..d0163c2 100644
--- a/src/tests/test_demo_effects.cc
+++ b/src/tests/test_demo_effects.cc
@@ -121,17 +121,17 @@ static void test_scene_effects() {
 
   // Test each scene effect
   std::vector<std::pair<const char*, std::shared_ptr<Effect>>> effects = {
-      // {"HeptagonEffect", std::make_shared<HeptagonEffect>(fixture.ctx())},
-      // {"ParticlesEffect", std::make_shared<ParticlesEffect>(fixture.ctx())},
-      // {"ParticleSprayEffect",
-      //  std::make_shared<ParticleSprayEffect>(fixture.ctx())},
-      // {"MovingEllipseEffect",
-      //  std::make_shared<MovingEllipseEffect>(fixture.ctx())},
-      // {"FlashCubeEffect", std::make_shared<FlashCubeEffect>(fixture.ctx())},
-      // {"Hybrid3DEffect", std::make_shared<Hybrid3DEffect>(fixture.ctx())},
-      // {"CircleMaskEffect", std::make_shared<CircleMaskEffect>(fixture.ctx())},
-      // {"RotatingCubeEffect",
-      //  std::make_shared<RotatingCubeEffect>(fixture.ctx())},
+      {"HeptagonEffect", std::make_shared<HeptagonEffect>(fixture.ctx())},
+      {"ParticlesEffect", std::make_shared<ParticlesEffect>(fixture.ctx())},
+      {"ParticleSprayEffect",
+       std::make_shared<ParticleSprayEffect>(fixture.ctx())},
+      {"MovingEllipseEffect",
+       std::make_shared<MovingEllipseEffect>(fixture.ctx())},
+      {"FlashCubeEffect", std::make_shared<FlashCubeEffect>(fixture.ctx())},
+      {"Hybrid3DEffect", std::make_shared<Hybrid3DEffect>(fixture.ctx())},
+      {"CircleMaskEffect", std::make_shared<CircleMaskEffect>(fixture.ctx())},
+      {"RotatingCubeEffect",
+       std::make_shared<RotatingCubeEffect>(fixture.ctx())},
   };
 
   int passed = 0;
-- 
cgit v1.2.3