From bb4f36f9c32a1484b62e80630825cbcec3976cad Mon Sep 17 00:00:00 2001
From: skal <pascal.massimino@gmail.com>
Date: Mon, 16 Feb 2026 21:41:59 +0100
Subject: refactor: complete removal of 'Effect' suffix from C++ class names
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Update effect class definitions in headers and implementations to match
timeline.seq naming convention. All tests passing (34/34).

Classes renamed:
- PassthroughEffect → Passthrough
- GaussianBlurEffect → GaussianBlur
- PlaceholderEffect → Placeholder
- HeptagonEffect → Heptagon
- ParticlesEffect → Particles
- RotatingCubeEffect → RotatingCube
- Hybrid3DEffect → Hybrid3D
- FlashEffect → Flash
- PeakMeterEffect → PeakMeter

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
---
 src/tests/gpu/test_demo_effects.cc | 36 ++++++++++++++++++------------------
 src/tests/gpu/test_effect_base.cc  | 10 +++++-----
 src/tests/gpu/test_sequence_e2e.cc |  4 ++--
 3 files changed, 25 insertions(+), 25 deletions(-)

(limited to 'src/tests/gpu')

diff --git a/src/tests/gpu/test_demo_effects.cc b/src/tests/gpu/test_demo_effects.cc
index cebf4a6..d012afb 100644
--- a/src/tests/gpu/test_demo_effects.cc
+++ b/src/tests/gpu/test_demo_effects.cc
@@ -37,40 +37,40 @@ static void test_effects() {
   }
 
   std::vector<std::pair<const char*, std::shared_ptr<Effect>>> effects = {
-      {"PassthroughEffect",
-       std::make_shared<PassthroughEffect>(
+      {"Passthrough",
+       std::make_shared<Passthrough>(
            fixture.ctx(), std::vector<std::string>{"source"},
            std::vector<std::string>{"sink"})},
-      {"GaussianBlurEffect",
-       std::make_shared<GaussianBlurEffect>(
+      {"GaussianBlur",
+       std::make_shared<GaussianBlur>(
            fixture.ctx(), std::vector<std::string>{"source"},
            std::vector<std::string>{"sink"})},
-      {"PlaceholderEffect",
-       std::make_shared<PlaceholderEffect>(
+      {"Placeholder",
+       std::make_shared<Placeholder>(
            fixture.ctx(), std::vector<std::string>{"source"},
            std::vector<std::string>{"sink"})},
-      {"HeptagonEffect",
-       std::make_shared<HeptagonEffect>(
+      {"Heptagon",
+       std::make_shared<Heptagon>(
            fixture.ctx(), std::vector<std::string>{"source"},
            std::vector<std::string>{"sink"})},
-      {"ParticlesEffect",
-       std::make_shared<ParticlesEffect>(
+      {"Particles",
+       std::make_shared<Particles>(
            fixture.ctx(), std::vector<std::string>{"source"},
            std::vector<std::string>{"sink"})},
-      {"RotatingCubeEffect",
-       std::make_shared<RotatingCubeEffect>(
+      {"RotatingCube",
+       std::make_shared<RotatingCube>(
            fixture.ctx(), std::vector<std::string>{"source"},
            std::vector<std::string>{"sink"})},
-      {"Hybrid3DEffect",
-       std::make_shared<Hybrid3DEffect>(
+      {"Hybrid3D",
+       std::make_shared<Hybrid3D>(
            fixture.ctx(), std::vector<std::string>{"source"},
            std::vector<std::string>{"sink"})},
-      {"FlashEffect",
-       std::make_shared<FlashEffect>(
+      {"Flash",
+       std::make_shared<Flash>(
            fixture.ctx(), std::vector<std::string>{"source"},
            std::vector<std::string>{"sink"})},
-      {"PeakMeterEffect",
-       std::make_shared<PeakMeterEffect>(
+      {"PeakMeter",
+       std::make_shared<PeakMeter>(
            fixture.ctx(), std::vector<std::string>{"source"},
            std::vector<std::string>{"sink"})},
   };
diff --git a/src/tests/gpu/test_effect_base.cc b/src/tests/gpu/test_effect_base.cc
index 8b0e6b2..ecf1dca 100644
--- a/src/tests/gpu/test_effect_base.cc
+++ b/src/tests/gpu/test_effect_base.cc
@@ -80,14 +80,14 @@ static void test_effect_construction() {
     return;
   }
 
-  // Create PassthroughEffect (simple effect)
-  auto effect = std::make_shared<PassthroughEffect>(
+  // Create Passthrough (simple effect)
+  auto effect = std::make_shared<Passthrough>(
       fixture.ctx(), std::vector<std::string>{"source"},
       std::vector<std::string>{"sink"});
 
   assert(effect != nullptr && "Effect should be constructed");
 
-  fprintf(stdout, "  ✓ PassthroughEffect constructed\n");
+  fprintf(stdout, "  ✓ Passthrough constructed\n");
 }
 
 // Test 4: Effect added to sequence DAG
@@ -104,7 +104,7 @@ static void test_effect_in_sequence() {
   class TestSequence : public Sequence {
   public:
     TestSequence(const GpuContext& ctx, int w, int h) : Sequence(ctx, w, h) {
-      auto effect = std::make_shared<PassthroughEffect>(
+      auto effect = std::make_shared<Passthrough>(
           ctx, std::vector<std::string>{"source"},
           std::vector<std::string>{"sink"});
 
@@ -136,7 +136,7 @@ static void test_sequence_render() {
   class TestSequence : public Sequence {
   public:
     TestSequence(const GpuContext& ctx, int w, int h) : Sequence(ctx, w, h) {
-      auto effect = std::make_shared<PassthroughEffect>(
+      auto effect = std::make_shared<Passthrough>(
           ctx, std::vector<std::string>{"source"},
           std::vector<std::string>{"sink"});
 
diff --git a/src/tests/gpu/test_sequence_e2e.cc b/src/tests/gpu/test_sequence_e2e.cc
index 91a8da2..46c6ec1 100644
--- a/src/tests/gpu/test_sequence_e2e.cc
+++ b/src/tests/gpu/test_sequence_e2e.cc
@@ -22,7 +22,7 @@ class SimpleTestSequence : public Sequence {
 
     // Effect DAG construction (2 effects: source->temp->sink)
     effect_dag_.push_back({
-      .effect = std::make_shared<PassthroughEffect>(ctx,
+      .effect = std::make_shared<Passthrough>(ctx,
                 std::vector<std::string>{"source"},
                 std::vector<std::string>{"temp"}),
       .input_nodes = {"source"},
@@ -30,7 +30,7 @@ class SimpleTestSequence : public Sequence {
       .execution_order = 0
     });
     effect_dag_.push_back({
-      .effect = std::make_shared<PassthroughEffect>(ctx,
+      .effect = std::make_shared<Passthrough>(ctx,
                 std::vector<std::string>{"temp"},
                 std::vector<std::string>{"sink"}),
       .input_nodes = {"temp"},
-- 
cgit v1.2.3