From bdb1a4e95a545f3f4d88630b8aec6ab771776d99 Mon Sep 17 00:00:00 2001 From: skal Date: Tue, 17 Feb 2026 13:05:11 +0100 Subject: refactor(effects): Streamline uniforms initialization Centralized uniforms_buffer_ initialization and updates to Effect base class: - init_uniforms_buffer() now automatic in Effect::Effect() - uniforms_buffer_.update() now automatic in dispatch_render() - Removed redundant calls from all effect subclasses - Updated effect.h comments to reflect automatic behavior - Updated EFFECT_WORKFLOW.md templates Benefits: - 16 lines removed from effect implementations - Consistent pattern enforced at compile time - Reduced boilerplate for new effects Tests: 34/34 passing handoff(Claude): Effect base class now handles uniforms automatically --- src/gpu/effect.cc | 6 ++---- src/gpu/effect.h | 13 +++++-------- 2 files changed, 7 insertions(+), 12 deletions(-) (limited to 'src/gpu') diff --git a/src/gpu/effect.cc b/src/gpu/effect.cc index d0693ec..a94b4a0 100644 --- a/src/gpu/effect.cc +++ b/src/gpu/effect.cc @@ -15,6 +15,7 @@ Effect::Effect(const GpuContext& ctx, const std::vector& inputs, FATAL_CHECK(start_time <= end_time, "Invalid time range: %f > %f\n", start_time, end_time); HEADLESS_RETURN_IF_NULL(ctx_.device); + uniforms_buffer_.init(ctx_.device); } void Effect::dispatch_render(WGPUCommandEncoder encoder, @@ -28,6 +29,7 @@ void Effect::dispatch_render(WGPUCommandEncoder encoder, if (!active && input_nodes_.size() == 1 && output_nodes_.size() == 1) { blit_input_to_output(encoder, nodes); } else if (active) { + uniforms_buffer_.update(ctx_.queue, params); render(encoder, params, nodes); } // Multi-output effects: output undefined when inactive (validated at compile time) @@ -57,10 +59,6 @@ void Effect::blit_input_to_output(WGPUCommandEncoder encoder, &extent); } -void Effect::init_uniforms_buffer() { - uniforms_buffer_.init(ctx_.device); -} - void Effect::create_linear_sampler() { sampler_.set(gpu_create_linear_sampler(ctx_.device)); } diff --git a/src/gpu/effect.h b/src/gpu/effect.h index d47a8b7..bfd5743 100644 --- a/src/gpu/effect.h +++ b/src/gpu/effect.h @@ -53,22 +53,19 @@ class Effect { int width_ = 1280; int height_ = 720; - // Common resources for most effects - UniformBuffer uniforms_buffer_; + // Common resources (initialized automatically in base class) + UniformBuffer uniforms_buffer_; // Auto-updated in dispatch_render() Sampler sampler_; Texture dummy_texture_; TextureView dummy_texture_view_; - // Helper: Initialize uniforms buffer (call in subclass constructor) - void init_uniforms_buffer(); - - // Helper: Create linear sampler (call in subclass constructor) + // Helper: Create linear sampler (call in subclass constructor if needed) void create_linear_sampler(); - // Helper: Create nearest sampler (call in subclass constructor) + // Helper: Create nearest sampler (call in subclass constructor if needed) void create_nearest_sampler(); - // Helper: Create dummy texture for scene effects (call in subclass constructor) + // Helper: Create dummy texture for scene effects (call in subclass constructor if needed) void create_dummy_scene_texture(); private: -- cgit v1.2.3