From e281b6ff0884a5b4af8aa2ca79fd01141bc2005b Mon Sep 17 00:00:00 2001 From: skal Date: Fri, 6 Feb 2026 10:16:50 +0100 Subject: refactor(build): Split asset_manager.h into dcl/core/utils headers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Split monolithic asset_manager.h (61 lines) into 3 focused headers: - asset_manager_dcl.h: Forward declarations (AssetId, ProcGenFunc) - asset_manager.h: Core API (GetAsset, DropAsset, AssetRecord) - asset_manager_utils.h: Typed helpers (TextureAsset, MeshAsset) Updated 17 source files to use appropriate headers: - object.h: Uses dcl.h (only needs AssetId forward declaration) - 7 files using TextureAsset/MeshAsset: Use utils.h - 10 files using only GetAsset(): Keep asset_manager.h Performance improvement: - Before: Touch asset_manager.h → 4.82s (35 files rebuild) - After: Touch asset_manager_utils.h → 2.01s (24 files rebuild) - Improvement: 58% faster for common workflow (tweaking mesh/texture helpers) Note: Touching base headers (dcl/core) still triggers ~33 file rebuilds due to object.h dependency chain. Further optimization would require reducing object.h's footprint (separate task). Files changed: - Created: asset_manager_dcl.h, asset_manager_utils.h - Modified: asset_manager.h (removed structs), asset_manager.cc - Updated: object.h, visual_debug.h, renderer_mesh.cc, flash_cube_effect.cc, hybrid_3d_effect.cc, test files --- src/gpu/effects/flash_cube_effect.cc | 2 +- src/gpu/effects/hybrid_3d_effect.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/gpu/effects') diff --git a/src/gpu/effects/flash_cube_effect.cc b/src/gpu/effects/flash_cube_effect.cc index 1c7b70c..75c71e1 100644 --- a/src/gpu/effects/flash_cube_effect.cc +++ b/src/gpu/effects/flash_cube_effect.cc @@ -4,7 +4,7 @@ #include "gpu/effects/flash_cube_effect.h" #include "generated/assets.h" -#include "util/asset_manager.h" +#include "util/asset_manager_utils.h" #include #include diff --git a/src/gpu/effects/hybrid_3d_effect.cc b/src/gpu/effects/hybrid_3d_effect.cc index cb77fef..8c70c07 100644 --- a/src/gpu/effects/hybrid_3d_effect.cc +++ b/src/gpu/effects/hybrid_3d_effect.cc @@ -3,7 +3,7 @@ #include "gpu/effects/hybrid_3d_effect.h" #include "generated/assets.h" -#include "util/asset_manager.h" +#include "util/asset_manager_utils.h" #include #include #include -- cgit v1.2.3