From e50db1721f67a6c1b565b0ac151ba32fcae21cbf Mon Sep 17 00:00:00 2001 From: skal Date: Mon, 9 Feb 2026 10:34:01 +0100 Subject: fix: Resolve WebGPU uniform buffer alignment issues (Task #74) Fixed multiple WGSL/C++ struct alignment mismatches causing validation errors: Padding fixes: - fade_effect.cc: Changed EffectParams padding from vec3 to _pad0/1/2 - theme_modulation_effect.cc: Same padding fix for EffectParams - Root cause: WGSL vec3 has 16-byte alignment, creating 32-byte structs ODR violation fix: - demo_effects.h: Added includes for fade_effect.h, theme_modulation_effect.h - Removed incomplete forward declarations (88 bytes) conflicting with complete definitions (96 bytes), causing heap buffer overflow in make_shared Member shadowing cleanup: - Renamed Effect::uniforms_ shadowing members to descriptive names: - FadeEffect: uniforms_ -> common_uniforms_ - FlashEffect: uniforms_ -> flash_uniforms_ - ThemeModulationEffect: uniforms_ -> common_uniforms_ Results: - demo64k runs without crashes - 33/33 tests passing (100%) - Added Task #75: WGSL uniform validation tool handoff(Claude): Uniform buffer alignment debugged and fixed --- src/gpu/effects/theme_modulation_effect.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/gpu/effects/theme_modulation_effect.h') diff --git a/src/gpu/effects/theme_modulation_effect.h b/src/gpu/effects/theme_modulation_effect.h index b972509..107529b 100644 --- a/src/gpu/effects/theme_modulation_effect.h +++ b/src/gpu/effects/theme_modulation_effect.h @@ -16,6 +16,6 @@ class ThemeModulationEffect : public PostProcessEffect { void update_bind_group(WGPUTextureView input_view) override; private: - UniformBuffer uniforms_; + UniformBuffer common_uniforms_; GpuBuffer params_buffer_; }; -- cgit v1.2.3