From d378da77eec4d506bc01e4c08c38644d72969cc7 Mon Sep 17 00:00:00 2001
From: skal <pascal.massimino@gmail.com>
Date: Wed, 11 Feb 2026 11:34:08 +0100
Subject: refactor: Simplify effect render API and fix uniform initialization
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Root cause: Uniform buffers created but not initialized before bind group
creation, causing undefined UV coordinates in circle_mask_compute.wgsl.

Changes:
- Add get_common_uniforms() helper to Effect base class
- Refactor render()/compute() signatures: 5 params → CommonPostProcessUniforms&
- Fix uninitialized uniforms in CircleMaskEffect and CNNEffect
- Update all 19 effect implementations and headers
- Fix WGSL syntax error in FlashEffect (u.audio_intensity → audio_intensity)
- Update test files (test_sequence.cc)

Benefits:
- Cleaner API: construct uniforms once per frame, reuse across effects
- More maintainable: CommonPostProcessUniforms changes need no call site updates
- Fixes UV coordinate bug in circle_mask_compute.wgsl

All 36 tests passing (100%)

handoff(Claude): Effect API refactor complete
---
 src/gpu/effects/cnn_effect.cc | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

(limited to 'src/gpu/effects/cnn_effect.cc')

diff --git a/src/gpu/effects/cnn_effect.cc b/src/gpu/effects/cnn_effect.cc
index e12c26f..3f6d3b3 100644
--- a/src/gpu/effects/cnn_effect.cc
+++ b/src/gpu/effects/cnn_effect.cc
@@ -53,6 +53,9 @@ void CNNEffect::init(MainSequence* demo) {
   demo_ = demo;
   params_buffer_.init(ctx_.device);
 
+  // Initialize uniforms BEFORE any bind group creation
+  uniforms_.update(ctx_.queue, get_common_uniforms());
+
   // Register captured_frame texture (used by all layers for original input)
   if (layer_index_ == 0) {
     demo_->register_auxiliary_texture("captured_frame", width_, height_);
@@ -62,8 +65,9 @@ void CNNEffect::init(MainSequence* demo) {
   params_buffer_.update(ctx_.queue, params);
 }
 
-void CNNEffect::render(WGPURenderPassEncoder pass, float time, float beat,
-                      float intensity, float aspect_ratio) {
+void CNNEffect::render(WGPURenderPassEncoder pass,
+                      const CommonPostProcessUniforms& uniforms) {
+  (void)uniforms;
   if (!bind_group_) {
     fprintf(stderr, "CNN render: no bind_group\n");
     return;
@@ -78,14 +82,7 @@ void CNNEffect::update_bind_group(WGPUTextureView input_view) {
   input_view_ = input_view;
 
   // Update common uniforms (CRITICAL for UV calculation!)
-  const CommonPostProcessUniforms u = {
-      .resolution = {(float)width_, (float)height_},
-      .aspect_ratio = (float)width_ / (float)height_,
-      .time = 0.0f,
-      .beat = 0.0f,
-      .audio_intensity = 0.0f,
-  };
-  uniforms_.update(ctx_.queue, u);
+  uniforms_.update(ctx_.queue, get_common_uniforms());
 
   // All layers: get captured frame (original input from layer 0)
   if (demo_) {
-- 
cgit v1.2.3