From 5d20c892dedce7bc7486acbd72fbd35da69e413e Mon Sep 17 00:00:00 2001 From: skal Date: Wed, 20 May 2026 22:44:44 +0200 Subject: fix: code review cleanup — bugs, dead code, factorization (-167 lines) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bugs: - B1: fix dead tempo debug (prev_tempo captured after assignment) - B2: fix ReloadAssetsFromFile leak for disk-loaded assets; simplify DropAsset - B3: fix get_free_pool_slot leak (unregister synth + free data on reuse) - B4: volatile -> std::atomic with acquire/release in miniaudio_backend, synth - B5: fix unaligned reads in scene_loader (memcpy-based read_f32/read_u32) - B6: fix shader module + BGL + pipeline layout leaks in gpu.cc, pipeline_builder Dead code: - D1: remove unused particle_defs.h - D3: remove create_post_process_pipeline_simple (zero callers) - D4: remove empty gpu_draw() - D5: remove write-only Hybrid3D::initialized_ - D6: remove legacy pending buffer path in audio.cc Factorization: - F1: Effect::run_fullscreen_pass() replaces boilerplate in 5 effects - F2: particle_common.wgsl snippet, #include in 3 WGSL shaders - F3: gpu_create_shader_module() helper, used in 3 call sites - F5: get_world_aabb() shared between bvh.cc and physics.cc - F6: samples_to_seconds() replaces 6 inline expressions - F7: gpu_create_linear/nearest_sampler use SamplerCache; add nearest() preset 37/37 tests passing. handoff(Claude): code review batch — all items verified, no regressions. --- src/gpu/effect.h | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src/gpu/effect.h') diff --git a/src/gpu/effect.h b/src/gpu/effect.h index 70ba9be..47dd3c2 100644 --- a/src/gpu/effect.h +++ b/src/gpu/effect.h @@ -79,6 +79,13 @@ class Effect { // consumer). Returns "" if no such effect exists or it has no outputs. std::string find_downstream_output(const std::vector& dag) const; + // Helper: Run a fullscreen triangle pass (pipeline + bind_group → output) + static void run_fullscreen_pass(WGPUCommandEncoder encoder, + WGPURenderPipeline pipeline, + WGPUBindGroup bind_group, + WGPUTextureView output_view, + WGPULoadOp load_op = WGPULoadOp_Clear); + // Helper: Create linear sampler (call in subclass constructor if needed) void create_linear_sampler(); -- cgit v1.2.3