From a91f89c8ea15665853176c05597760d0fcf6e0df Mon Sep 17 00:00:00 2001 From: skal Date: Wed, 20 May 2026 22:44:44 +0200 Subject: fix: code review cleanup — bugs, dead code, factorization, simplification MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bugs: - B1: fix dead tempo debug (prev_tempo captured after assignment) - B2: fix ReloadAssetsFromFile leak for disk-loaded assets; simplify DropAsset - B3: fix get_free_pool_slot leak (unregister synth + free data on reuse) - B4: volatile -> std::atomic with acquire/release in miniaudio_backend, synth - B5: fix unaligned reads in scene_loader (memcpy-based read_f32/read_u32) - B6: fix shader module + BGL + pipeline layout leaks in gpu.cc, pipeline_builder Dead code: - D1: remove unused particle_defs.h - D3: remove create_post_process_pipeline_simple (zero callers) - D4: remove empty gpu_draw() - D5: remove write-only Hybrid3D::initialized_ - D6: remove legacy pending buffer path in audio.cc Factorization: - F1: Effect::run_fullscreen_pass() replaces boilerplate in 5 effects - F2: particle_common.wgsl snippet, #include in 3 WGSL shaders - F3: gpu_create_shader_module() helper, used in 3 call sites - F5: get_world_aabb() shared between bvh.cc and physics.cc - F6: samples_to_seconds() replaces 6 inline expressions - F7: gpu_create_linear/nearest_sampler use SamplerCache; add nearest() preset Simplification: - S9+S1: WgslSamplerType param; Scene2Effect collapsed to thin wrapper - S4: FFT heap allocs -> stack arrays (zero allocs on hot path) - S5: ObjectType::CUBE documented as legacy alias for BOX; default changed - S6: bind group dirty-flag in Renderer3D; remove duplicate pipeline set - S7: create_gpu_procedural() helper in texture_manager (~80 lines removed) 37/37 tests passing. handoff(Claude): code review batch — all items verified, no regressions. --- src/effects/scene2_effect.cc | 34 ---------------------------------- src/effects/scene2_effect.h | 19 +++++++------------ 2 files changed, 7 insertions(+), 46 deletions(-) delete mode 100644 src/effects/scene2_effect.cc (limited to 'src/effects') diff --git a/src/effects/scene2_effect.cc b/src/effects/scene2_effect.cc deleted file mode 100644 index 92e5ecd..0000000 --- a/src/effects/scene2_effect.cc +++ /dev/null @@ -1,34 +0,0 @@ -// This file is part of the 64k demo project. -// Scene2 effect - ShaderToy conversion (scene) -// Generated by convert_shadertoy.py - -#include "effects/scene2_effect.h" -#include "effects/shaders.h" -#include "gpu/gpu.h" -#include "gpu/post_process_helper.h" -#include "util/fatal_error.h" - -Scene2Effect::Scene2Effect(const GpuContext& ctx, - const std::vector& inputs, - const std::vector& outputs, - float start_time, float end_time) - : Effect(ctx, inputs, outputs, start_time, end_time) { - HEADLESS_RETURN_IF_NULL(ctx_.device); - create_nearest_sampler(); - create_dummy_scene_texture(); - pipeline_.set(create_post_process_pipeline( - ctx_.device, WGPUTextureFormat_RGBA8Unorm, scene2_shader_wgsl)); -} - -void Scene2Effect::render(WGPUCommandEncoder encoder, - const UniformsSequenceParams& params, - NodeRegistry& nodes) { - WGPUTextureView output_view = nodes.get_view(output_nodes_[0]); - - // uniforms_buffer_ auto-updated by base class dispatch_render() - pp_update_bind_group(ctx_.device, pipeline_.get(), bind_group_.get_address(), - dummy_texture_view_.get(), uniforms_buffer_.get(), - {nullptr, 0}); - - run_fullscreen_pass(encoder, pipeline_.get(), bind_group_.get(), output_view); -} diff --git a/src/effects/scene2_effect.h b/src/effects/scene2_effect.h index da4cf7e..0e26fc3 100644 --- a/src/effects/scene2_effect.h +++ b/src/effects/scene2_effect.h @@ -4,19 +4,14 @@ #pragma once -#include "gpu/effect.h" -#include "gpu/wgpu_resource.h" +#include "effects/shaders.h" +#include "gpu/wgsl_effect.h" -class Scene2Effect : public Effect { - public: +struct Scene2Effect : public WgslEffect { Scene2Effect(const GpuContext& ctx, const std::vector& inputs, const std::vector& outputs, float start_time, - float end_time); - - void render(WGPUCommandEncoder encoder, const UniformsSequenceParams& params, - NodeRegistry& nodes) override; - - private: - RenderPipeline pipeline_; - BindGroup bind_group_; + float end_time) + : WgslEffect(ctx, inputs, outputs, start_time, end_time, + scene2_shader_wgsl, WGPULoadOp_Clear, {}, + WgslSamplerType::Nearest) {} }; -- cgit v1.2.3