From 42de5c4e5aeb486b4afb5b73bcb6a9d5ba567cbd Mon Sep 17 00:00:00 2001 From: skal Date: Mon, 16 Feb 2026 15:15:40 +0100 Subject: fix(headless): add nullptr checks for GPU resource creation - NodeRegistry::create_texture: skip texture creation when device is nullptr - Post-process helpers: skip pipeline/bind group creation in headless mode - SamplerCache: return nullptr for headless mode - BindGroupLayoutBuilder/BindGroupBuilder: skip creation with null device - RenderPipelineBuilder: skip shader module and pipeline creation in headless - PlaceholderEffect: skip sampler creation in headless mode - RotatingCubeEffect: early return in constructor for headless mode WIP: Some effects (GaussianBlur, etc.) still need headless checks Co-Authored-By: Claude Sonnet 4.5 --- src/effects/placeholder_effect.cc | 21 ++++++++++++--------- src/effects/rotating_cube_effect.cc | 5 +++++ 2 files changed, 17 insertions(+), 9 deletions(-) (limited to 'src/effects') diff --git a/src/effects/placeholder_effect.cc b/src/effects/placeholder_effect.cc index d3308de..a83d922 100644 --- a/src/effects/placeholder_effect.cc +++ b/src/effects/placeholder_effect.cc @@ -18,15 +18,18 @@ PlaceholderEffect::PlaceholderEffect(const GpuContext& ctx, pipeline_ = create_post_process_pipeline(ctx_.device, WGPUTextureFormat_RGBA8Unorm, passthrough_v2_shader_wgsl); - WGPUSamplerDescriptor sampler_desc = {}; - sampler_desc.addressModeU = WGPUAddressMode_ClampToEdge; - sampler_desc.addressModeV = WGPUAddressMode_ClampToEdge; - sampler_desc.addressModeW = WGPUAddressMode_ClampToEdge; - sampler_desc.magFilter = WGPUFilterMode_Linear; - sampler_desc.minFilter = WGPUFilterMode_Linear; - sampler_desc.mipmapFilter = WGPUMipmapFilterMode_Nearest; - sampler_desc.maxAnisotropy = 1; - sampler_ = wgpuDeviceCreateSampler(ctx_.device, &sampler_desc); + // Headless mode: skip sampler creation + if (ctx_.device != nullptr) { + WGPUSamplerDescriptor sampler_desc = {}; + sampler_desc.addressModeU = WGPUAddressMode_ClampToEdge; + sampler_desc.addressModeV = WGPUAddressMode_ClampToEdge; + sampler_desc.addressModeW = WGPUAddressMode_ClampToEdge; + sampler_desc.magFilter = WGPUFilterMode_Linear; + sampler_desc.minFilter = WGPUFilterMode_Linear; + sampler_desc.mipmapFilter = WGPUMipmapFilterMode_Nearest; + sampler_desc.maxAnisotropy = 1; + sampler_ = wgpuDeviceCreateSampler(ctx_.device, &sampler_desc); + } } void PlaceholderEffect::render(WGPUCommandEncoder encoder, diff --git a/src/effects/rotating_cube_effect.cc b/src/effects/rotating_cube_effect.cc index 3f1d445..e7ed52e 100644 --- a/src/effects/rotating_cube_effect.cc +++ b/src/effects/rotating_cube_effect.cc @@ -10,6 +10,11 @@ RotatingCubeEffect::RotatingCubeEffect(const GpuContext& ctx, const std::vector& inputs, const std::vector& outputs) : Effect(ctx, inputs, outputs), depth_node_(outputs[0] + "_depth") { + // Headless mode: skip GPU resource creation + if (ctx_.device == nullptr) { + return; + } + // Create uniform buffers uniform_buffer_ = gpu_create_buffer(ctx_.device, sizeof(Uniforms), -- cgit v1.2.3