From 850388bcaabf057beed8f126002b7b663183b2d8 Mon Sep 17 00:00:00 2001
From: skal <pascal.massimino@gmail.com>
Date: Fri, 20 Feb 2026 12:08:34 +0100
Subject: feat(sequence): port Scene1Effect + fix seq_compiler absolute time
 bug
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Add Scene1 effect: raymarching cube+sphere+ground (reflections, shadows)
- Fix scene1.wgsl: binding 0→2, CommonUniforms→UniformsSequenceParams
- Replace Heptagon+Placeholder stub in heptagon_scene with Scene1
- Fix seq_compiler.py: emit seq.start_time+effect.start/end (absolute times)
  so dispatch_render active check works correctly for all sequences

Bug: effects in sequences starting after t=0 were never active because
local times (e.g. 0-8) never satisfied params.time<end for absolute time 20+.

34/34 tests passing.

handoff(Gemini): seq_compiler now emits absolute effect times. All existing
sequences affected — verify visual output across the full timeline.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 src/effects/scene1_effect.cc | 45 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 src/effects/scene1_effect.cc

(limited to 'src/effects/scene1_effect.cc')

diff --git a/src/effects/scene1_effect.cc b/src/effects/scene1_effect.cc
new file mode 100644
index 0000000..7c109e7
--- /dev/null
+++ b/src/effects/scene1_effect.cc
@@ -0,0 +1,45 @@
+// Scene1 effect implementation
+
+#include "effects/scene1_effect.h"
+#include "effects/shaders.h"
+#include "gpu/gpu.h"
+#include "gpu/post_process_helper.h"
+#include "util/fatal_error.h"
+
+Scene1::Scene1(const GpuContext& ctx, const std::vector<std::string>& inputs,
+               const std::vector<std::string>& outputs, float start_time,
+               float end_time)
+    : Effect(ctx, inputs, outputs, start_time, end_time) {
+  HEADLESS_RETURN_IF_NULL(ctx_.device);
+
+  create_nearest_sampler();
+  create_dummy_scene_texture();
+
+  pipeline_.set(create_post_process_pipeline(
+      ctx_.device, WGPUTextureFormat_RGBA8Unorm, scene1_shader_wgsl));
+}
+
+void Scene1::render(WGPUCommandEncoder encoder,
+                    const UniformsSequenceParams& params,
+                    NodeRegistry& nodes) {
+  WGPUTextureView output_view = nodes.get_view(output_nodes_[0]);
+
+  pp_update_bind_group(ctx_.device, pipeline_.get(), bind_group_.get_address(),
+                       dummy_texture_view_.get(), uniforms_buffer_.get(),
+                       {nullptr, 0});
+
+  WGPURenderPassColorAttachment color_attachment = {};
+  gpu_init_color_attachment(color_attachment, output_view);
+
+  WGPURenderPassDescriptor pass_desc = {};
+  pass_desc.colorAttachmentCount = 1;
+  pass_desc.colorAttachments = &color_attachment;
+
+  WGPURenderPassEncoder pass =
+      wgpuCommandEncoderBeginRenderPass(encoder, &pass_desc);
+  wgpuRenderPassEncoderSetPipeline(pass, pipeline_.get());
+  wgpuRenderPassEncoderSetBindGroup(pass, 0, bind_group_.get(), 0, nullptr);
+  wgpuRenderPassEncoderDraw(pass, 3, 1, 0, 0); // Fullscreen triangle
+  wgpuRenderPassEncoderEnd(pass);
+  wgpuRenderPassEncoderRelease(pass);
+}
-- 
cgit v1.2.3