From e281b6ff0884a5b4af8aa2ca79fd01141bc2005b Mon Sep 17 00:00:00 2001
From: skal <pascal.massimino@gmail.com>
Date: Fri, 6 Feb 2026 10:16:50 +0100
Subject: refactor(build): Split asset_manager.h into dcl/core/utils headers
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Split monolithic asset_manager.h (61 lines) into 3 focused headers:
- asset_manager_dcl.h: Forward declarations (AssetId, ProcGenFunc)
- asset_manager.h: Core API (GetAsset, DropAsset, AssetRecord)
- asset_manager_utils.h: Typed helpers (TextureAsset, MeshAsset)

Updated 17 source files to use appropriate headers:
- object.h: Uses dcl.h (only needs AssetId forward declaration)
- 7 files using TextureAsset/MeshAsset: Use utils.h
- 10 files using only GetAsset(): Keep asset_manager.h

Performance improvement:
- Before: Touch asset_manager.h → 4.82s (35 files rebuild)
- After:  Touch asset_manager_utils.h → 2.01s (24 files rebuild)
- Improvement: 58% faster for common workflow (tweaking mesh/texture helpers)

Note: Touching base headers (dcl/core) still triggers ~33 file rebuilds
due to object.h dependency chain. Further optimization would require
reducing object.h's footprint (separate task).

Files changed:
- Created: asset_manager_dcl.h, asset_manager_utils.h
- Modified: asset_manager.h (removed structs), asset_manager.cc
- Updated: object.h, visual_debug.h, renderer_mesh.cc,
  flash_cube_effect.cc, hybrid_3d_effect.cc, test files
---
 src/3d/object.h         | 2 +-
 src/3d/renderer_mesh.cc | 2 +-
 src/3d/visual_debug.cc  | 2 +-
 src/3d/visual_debug.h   | 1 +
 4 files changed, 4 insertions(+), 3 deletions(-)

(limited to 'src/3d')

diff --git a/src/3d/object.h b/src/3d/object.h
index 3d4ff35..c2d9ba1 100644
--- a/src/3d/object.h
+++ b/src/3d/object.h
@@ -5,7 +5,7 @@
 #pragma once
 
 #include "util/mini_math.h"
-#include "util/asset_manager.h"
+#include "util/asset_manager_dcl.h"
 
 enum class ObjectType {
   CUBE,
diff --git a/src/3d/renderer_mesh.cc b/src/3d/renderer_mesh.cc
index 97b91d3..0a098ef 100644
--- a/src/3d/renderer_mesh.cc
+++ b/src/3d/renderer_mesh.cc
@@ -4,7 +4,7 @@
 #include "3d/renderer.h"
 #include "generated/assets.h"
 #include "gpu/effects/shader_composer.h"
-#include "util/asset_manager.h"
+#include "util/asset_manager_utils.h"
 #include <cstring>
 #include <vector>
 
diff --git a/src/3d/visual_debug.cc b/src/3d/visual_debug.cc
index 009a1e1..9667d87 100644
--- a/src/3d/visual_debug.cc
+++ b/src/3d/visual_debug.cc
@@ -6,7 +6,7 @@
 #if !defined(STRIP_ALL)
 
 #include "generated/assets.h"
-#include "util/asset_manager.h"
+#include "util/asset_manager_utils.h"
 #include <cstdio>
 #include <cstring>
 
diff --git a/src/3d/visual_debug.h b/src/3d/visual_debug.h
index ebccf45..505a799 100644
--- a/src/3d/visual_debug.h
+++ b/src/3d/visual_debug.h
@@ -8,6 +8,7 @@
 
 #include "gpu/gpu.h"
 #include "util/mini_math.h"
+#include "util/asset_manager_utils.h"
 #include "3d/object.h"
 #include <vector>
 
-- 
cgit v1.2.3