From e4851ae9f310b44dab25eb979733281002c8953d Mon Sep 17 00:00:00 2001 From: skal Date: Sat, 7 Mar 2026 19:02:07 +0100 Subject: refactor(effects): introduce WgslEffect for shader-only post-process effects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace boilerplate .h/.cc pairs for simple single-pass effects with a generic WgslEffect base class that takes a shader string + optional WgslEffectParams (binding 3). Port Flash, Passthrough, Heptagon, Scratch, and GaussianBlur to thin header-only wrappers — no .cc files, no CMake entries needed. Removes 5 .cc files (-243 lines). Update EFFECT_WORKFLOW.md, CONTRIBUTING.md, and AI_RULES.md to document the WgslEffect (Path A) vs full class (Path B) workflow. Doc cleanup: fix stale GaussianBlurParams/PostProcessEffect references and test counts. handoff(Claude): WgslEffect landed; 5 effects ported; docs updated. Co-Authored-By: Claude Sonnet 4.6 --- cmake/DemoSourceLists.cmake | 6 +----- cmake/Validation.cmake | 4 +--- 2 files changed, 2 insertions(+), 8 deletions(-) (limited to 'cmake') diff --git a/cmake/DemoSourceLists.cmake b/cmake/DemoSourceLists.cmake index 1aaef59..3917fcd 100644 --- a/cmake/DemoSourceLists.cmake +++ b/cmake/DemoSourceLists.cmake @@ -32,18 +32,14 @@ set(UTIL_SOURCES src/util/asset_manager.cc src/util/file_watcher.cc) set(COMMON_GPU_EFFECTS src/gpu/sequence.cc src/gpu/effect.cc - src/effects/passthrough_effect.cc + src/gpu/wgsl_effect.cc src/effects/placeholder_effect.cc - src/effects/gaussian_blur_effect.cc - src/effects/heptagon_effect.cc src/effects/particles_effect.cc src/effects/rotating_cube_effect.cc src/effects/hybrid3_d_effect.cc - src/effects/flash_effect.cc src/effects/peak_meter_effect.cc src/effects/scene1_effect.cc src/effects/scene2_effect.cc - src/effects/scratch_effect.cc # TODO: Port CNN effects to v2 (complex v1 dependencies) # cnn_v1/src/cnn_v1_effect.cc # cnn_v2/src/cnn_v2_effect.cc diff --git a/cmake/Validation.cmake b/cmake/Validation.cmake index b4a3784..beee832 100644 --- a/cmake/Validation.cmake +++ b/cmake/Validation.cmake @@ -14,9 +14,7 @@ file(GLOB WGSL_FILES RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE set(VALIDATION_CPP_FILES ${CMAKE_CURRENT_SOURCE_DIR}/src/gpu/post_process_helper.h ${CMAKE_CURRENT_SOURCE_DIR}/src/gpu/demo_effects.h - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/heptagon_effect.cc - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/gaussian_blur_effect.cc - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/passthrough_effect.cc + ${CMAKE_CURRENT_SOURCE_DIR}/src/gpu/wgsl_effect.h ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/placeholder_effect.cc ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/particles_effect.cc ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/rotating_cube_effect.cc -- cgit v1.2.3