From af5d0e4c3a6cb773a4fb51ac32f4c33a7f8d8224 Mon Sep 17 00:00:00 2001 From: skal Date: Mon, 16 Feb 2026 11:54:46 +0100 Subject: feat(sequence): complete v2 migration with DAG-based routing Phase 4 complete: V1 system removed, v2 fully operational. Architecture Changes: - Explicit Node system with typed buffers (u8x4_norm, f32x4, depth24) - DAG effect routing with multi-input/multi-output support - Python compiler (seq_compiler_v2.py) with topological sort and ping-pong optimization - Compile-time node aliasing for framebuffer reuse V1 Removal (~4KB): - Deleted effect.h/cc base classes (1.4KB) - Deleted 19 v1 effect pairs: heptagon, particles, passthrough, gaussian_blur, solarize, scene1, chroma_aberration, vignette, hybrid_3d, flash_cube, theme_modulation, fade, flash, circle_mask, rotating_cube, sdf_test, distort, moving_ellipse, particle_spray (2.7KB) V2 Effects Ported: - PassthroughEffectV2, PlaceholderEffectV2 - GaussianBlurEffectV2 (multi-pass with temp nodes) - HeptagonEffectV2 (scene effect with dummy texture) - ParticlesEffectV2 (compute + render, format fixed) - RotatingCubeEffectV2 (3D with depth node) - Hybrid3DEffectV2 (Renderer3D integration, dummy textures for noise/sky) Compiler Features: - DAG validation (cycle detection, connectivity checks) - Topological sort for execution order - Ping-pong optimization (aliased node detection) - Surface-based and encoder-based RenderV2Timeline generation - init_effect_nodes() automatic generation Fixes Applied: - WebGPU binding layout validation (standard v2 post-process layout) - Surface format mismatch (ctx.format for blit, RGBA8Unorm for framebuffers) - Depth attachment compatibility (removed forced depth from gpu_create_render_pass) - Renderer3D texture initialization (created dummy 1x1 white textures) - ParticlesEffectV2 format (changed from ctx.format to RGBA8Unorm) - Encoder-based RenderV2Timeline (added missing preprocess() call) Testing: - 34/36 tests passing (2 v1-dependent tests disabled) - demo64k runs successfully (no crashes) - All seek positions work (--seek 12, --seek 15 validated) Documentation: - Updated PROJECT_CONTEXT.md (v2 status, reference to SEQUENCE_v2.md) - Added completion entry to COMPLETED.md TODO (Future): - Port CNN effects to v2 - Implement flatten mode (--flatten code generation) - Port remaining 10+ effects - Update HTML timeline editor for v2 (deferred) handoff(Claude): Sequence v2 migration complete, v1 removed, system operational. Phase 5 (editor) deferred per user preference. Co-Authored-By: Claude Sonnet 4.5 --- cmake/Validation.cmake | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) (limited to 'cmake/Validation.cmake') diff --git a/cmake/Validation.cmake b/cmake/Validation.cmake index 328357e..ee150f4 100644 --- a/cmake/Validation.cmake +++ b/cmake/Validation.cmake @@ -9,19 +9,18 @@ add_custom_target(validate_uniforms_script ALL DEPENDS ${CMAKE_CURRENT_SOURCE_DI # Find all WGSL files recursively in src/gpu file(GLOB WGSL_FILES RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}/src/gpu/*.wgsl ${CMAKE_CURRENT_SOURCE_DIR}/src/gpu/**/*.wgsl) -# List of C++ files containing uniform struct definitions and shader code +# List of C++ files containing uniform struct definitions and shader code (v2) # Add more C++ files here if new effects with structs are added. set(VALIDATION_CPP_FILES - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/heptagon_effect.cc ${CMAKE_CURRENT_SOURCE_DIR}/src/gpu/post_process_helper.h - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/fade_effect.cc - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/theme_modulation_effect.cc - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/chroma_aberration_effect.cc - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/vignette_effect.cc - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/gaussian_blur_effect.cc - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/distort_effect.cc ${CMAKE_CURRENT_SOURCE_DIR}/src/gpu/demo_effects.h - ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/circle_mask_effect.h + ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/heptagon_effect_v2.cc + ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/gaussian_blur_effect_v2.cc + ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/passthrough_effect_v2.cc + ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/placeholder_effect_v2.cc + ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/particles_effect_v2.cc + ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/rotating_cube_effect_v2.cc + ${CMAKE_CURRENT_SOURCE_DIR}/src/effects/hybrid3_d_effect_v2.cc ) # Add custom command to run the validator -- cgit v1.2.3