From 47312588d0ef37ea7ef19c97bc5089d419ae3cd9 Mon Sep 17 00:00:00 2001 From: skal Date: Mon, 23 Mar 2026 08:05:12 +0100 Subject: fix(cnn_v3_debug): add CNNv3Effect to debug sequence for prev.r/g/b temporal feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit timeline.seq is the canonical source — timeline.cc was wrongly hand-edited. Add CNNv3Effect + cnn_out (gbuf_albedo) node to cnn_v3_debug sequence so wire_dag() can wire GBufferEffect.cnn_output_node_ correctly. Also fix node_prev_tex_ NodeType: F16X8 (Rgba16Float+CopyDst) to match CNNv3Effect output format (GBUF_ALBEDO = Rgba16Float). Regenerated timeline.cc via: python3 tools/seq_compiler.py workspaces/main/timeline.seq Co-Authored-By: Claude Sonnet 4.6 --- cnn_v3/src/gbuffer_effect.cc | 3 ++- workspaces/main/timeline.seq | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cnn_v3/src/gbuffer_effect.cc b/cnn_v3/src/gbuffer_effect.cc index 1bfd685..6815154 100644 --- a/cnn_v3/src/gbuffer_effect.cc +++ b/cnn_v3/src/gbuffer_effect.cc @@ -96,7 +96,8 @@ void GBufferEffect::declare_nodes(NodeRegistry& registry) { if (!registry.has_node(output_nodes_[1])) { registry.declare_node(output_nodes_[1], NodeType::GBUF_RGBA32UINT, -1, -1); } - registry.declare_node(node_prev_tex_, NodeType::U8X4_NORM, -1, -1); + // F16X8 = Rgba16Float with CopySrc|CopyDst — matches CNNv3Effect output format. + registry.declare_node(node_prev_tex_, NodeType::F16X8, -1, -1); } void GBufferEffect::set_scene() { diff --git a/workspaces/main/timeline.seq b/workspaces/main/timeline.seq index 1b75cdc..1609910 100644 --- a/workspaces/main/timeline.seq +++ b/workspaces/main/timeline.seq @@ -52,5 +52,7 @@ SEQUENCE 48.00 1 "particles" SEQUENCE 52.00 0 "cnn_v3_debug" NODE gbuf_feat0 gbuf_rgba32uint NODE gbuf_feat1 gbuf_rgba32uint + NODE cnn_out gbuf_albedo EFFECT + GBufferEffect source -> gbuf_feat0 gbuf_feat1 0.00 120.00 + EFFECT + CNNv3Effect gbuf_feat0 gbuf_feat1 -> cnn_out 0.00 120.00 EFFECT + GBufViewEffect gbuf_feat0 gbuf_feat1 -> sink 0.00 120.00 -- cgit v1.2.3